Summary: | app-admin/syslog-ng-3.30.1: fails to compile with net-libs/libesmtp-1.0.6_p20200824 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Klemen Mihevc <solor> |
Component: | Current packages | Assignee: | Tomáš Mózes <hydrapolic> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | atoth, jaak, proteuss, proxy-maint, sam, vyedmic |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
URL: | https://github.com/syslog-ng/syslog-ng/issues/3646 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=782532 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
config.log build.log syslog-ng-3.32.1-libesmtp-pkg-check-modules-uppercase.patch syslog-ng-3.32.1-libesmtp-pkgconfig-upstream.patch |
Description
Klemen Mihevc
2021-04-13 09:02:09 UTC
Created attachment 699648 [details]
build.log
Created attachment 699651 [details]
config.log
Thanks for the report, confirmed on ~amd64. Will have to report this upstream. (In reply to Tomáš Mózes from comment #3) > Thanks for the report, confirmed on ~amd64. Will have to report this > upstream. Working on a quick patch. Need to use pkgconfig. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28e5e044aa65c4e3c1748716e7f0224fbfd94676 commit 28e5e044aa65c4e3c1748716e7f0224fbfd94676 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-04-13 20:47:10 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-04-13 22:37:39 +0000 app-admin/syslog-ng: use pkgconfig to find libesmtp The newer version of libesmtp (snapshot) drops autotools and dropped its homebrew libesmtp-config utility too. We now have to use pkgconfig to find it. Bug: https://bugs.gentoo.org/782643 Signed-off-by: Sam James <sam@gentoo.org> .../files/syslog-ng-3.30.1-esmtp-pkgconfig.patch | 26 ++++ app-admin/syslog-ng/syslog-ng-3.30.1-r1.ebuild | 173 +++++++++++++++++++++ 2 files changed, 199 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf2731095af25105762bb007d4d0f60956f4bbef commit bf2731095af25105762bb007d4d0f60956f4bbef Author: Sam James <sam@gentoo.org> AuthorDate: 2021-04-13 20:57:35 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-04-13 22:37:36 +0000 net-libs/libesmtp: add subslot 1.0.6 breaks ABI compatibility (severely). Bug: https://bugs.gentoo.org/782643 Signed-off-by: Sam James <sam@gentoo.org> net-libs/libesmtp/libesmtp-1.0.6_p20200824.ebuild | 2 +- net-libs/libesmtp/libesmtp-9999.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Huge thanks Sam! Works for me as well, thanks! Created attachment 700740 [details]
build.log
FYI I hit this today on syslog-ng-3.26.1-r1
(In reply to Joonas Niilola from comment #8) > Created attachment 700740 [details] > build.log > > FYI I hit this today on syslog-ng-3.26.1-r1 Right, that’s the stable version, but the new libesmtp is still in ~arch (In reply to Tomáš Mózes from comment #6) > Huge thanks Sam! No problem! We may want to add a fallback to checking -config (In reply to Larry the Git Cow from comment #5) > The bug has been referenced in the following commit(s): > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=28e5e044aa65c4e3c1748716e7f0224fbfd94676 I think this might have broken syslog-ng for me. It fails to start due to some "destination plugin smtp not found" error. It seems that libafsmtp.so is not properly linked to libesmtp, because when trying to run syslog-ng with --debug, I get something this: [2021-06-22T16:28:09.259455] Reading shared object for a candidate module; path='/usr/lib64/syslog-ng', fname='libafsmtp.so', module='afsmtp' [2021-06-22T16:28:09.259800] Error opening plugin module; module='afsmtp', error='/usr/lib64/syslog-ng/libafsmtp.so: undefined symbol: _smtp_message_str_cb' (In reply to Jaak Ristioja from comment #11) > (In reply to Larry the Git Cow from comment #5) > > The bug has been referenced in the following commit(s): > > > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > > ?id=28e5e044aa65c4e3c1748716e7f0224fbfd94676 > > I think this might have broken syslog-ng for me. It fails to start due to > some "destination plugin smtp not found" error. It seems that libafsmtp.so > is not properly linked to libesmtp, because when trying to run syslog-ng > with --debug, I get something this: > > [2021-06-22T16:28:09.259455] Reading shared object for a candidate module; > path='/usr/lib64/syslog-ng', fname='libafsmtp.so', module='afsmtp' > [2021-06-22T16:28:09.259800] Error opening plugin module; module='afsmtp', > error='/usr/lib64/syslog-ng/libafsmtp.so: undefined symbol: > _smtp_message_str_cb' The change has just been merged to syslog-ng upstream (https://github.com/syslog-ng/syslog-ng/pull/3669). Jaak, please post your $(emerge --info app-admin/syslog-ng). You may need to rebuild both libesmtp and syslog? I'm no autotools expert, but I think the incorrect linking is caused by the PKG_CHECK_MODULES line in syslog-ng-3.30.1-esmtp-pkgconfig.patch which is slightly incorrect: I suspect that the first argument to PKG_CHECK_MODULES() should be written in uppercase, as it currently seems to define libesmtp_LIBS instead of LIBESMTP_LIBS, and that seems to make a difference for the makefiles. Created attachment 719469 [details, diff]
syslog-ng-3.32.1-libesmtp-pkg-check-modules-uppercase.patch
You mean like this?
(In reply to Jaak Ristioja from comment #14) > I'm no autotools expert, but I think the incorrect linking is caused by the > PKG_CHECK_MODULES line in syslog-ng-3.30.1-esmtp-pkgconfig.patch which is > slightly incorrect: I suspect that the first argument to PKG_CHECK_MODULES() > should be written in uppercase, as it currently seems to define > libesmtp_LIBS instead of LIBESMTP_LIBS, and that seems to make a difference > for the makefiles. I attached a quick patch. Upstream merge also makes it uppercase: https://github.com/syslog-ng/syslog-ng/pull/3669/commits/b8284f8ecac588f6a321c779cce06cbe182611a5 Created attachment 719472 [details, diff]
syslog-ng-3.32.1-libesmtp-pkgconfig-upstream.patch
Quickpatch according to upstream commit.
Oh, of course. Will fix shortly, thanks. *** Bug 800431 has been marked as a duplicate of this bug. *** The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=998792c5836911dfcc891ec12bb250cf2a9c5550 commit 998792c5836911dfcc891ec12bb250cf2a9c5550 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-07-05 23:34:03 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-07-05 23:35:38 +0000 app-admin/syslog-ng: fix libesmtp pkg-config patch Closes: https://bugs.gentoo.org/782643 Signed-off-by: Sam James <sam@gentoo.org> .../files/syslog-ng-3.30.1-esmtp-pkgconfig.patch | 44 +++++++++++++++++----- ...3.30.1-r1.ebuild => syslog-ng-3.30.1-r2.ebuild} | 2 +- app-admin/syslog-ng/syslog-ng-3.30.1.ebuild | 2 +- ...ng-3.31.2.ebuild => syslog-ng-3.31.2-r1.ebuild} | 2 +- ...ng-3.32.1.ebuild => syslog-ng-3.32.1-r1.ebuild} | 2 +- 5 files changed, 38 insertions(+), 14 deletions(-) |