| Summary: | media-video/ffdiaporama-2.2_pre20140701-r2 fails to compile (error: ‘AVStream’ {aka ‘struct AVStream’} has no member named ‘probe_data’; did you mean ‘priv_data’?) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | laurantino <olivier.laurantin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | proxy-maint, sam |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/20408 | ||
| Whiteboard: | ffmpeg 4.4? | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 781146 | ||
| Attachments: | build.log | ||
|
Description
Agostino Sarubbo
2021-04-12 07:34:52 UTC
Created attachment 699354 [details]
build.log
build log and emerge --info
Possible context of error(s):
engine/_EncodeVideo.cpp:134:46: error: ‘AVStream’ {aka ‘struct AVStream’} has no member named ‘probe_data’; did you mean ‘priv_data’?
New ffmpeg issue? I confirm it is related to ffmpeg 4.4 (probe_data has been removed from the public API). The error is located in a portion of code which is now useless so it is easy to fix. I will submit a pull request as soon as I can. Stale project since 2014. Is it really needed or can we discard it? ;-) Good question ! ;-) i am just patching it as proxy maintainer but I am not using it very often and do not know if there are people using it. I would see no problem to keep it in my local repo. I let you decide! (In reply to laurantino from comment #6) > Good question ! ;-) > i am just patching it as proxy maintainer but I am not using it very often > and do not know if there are people using it. > I would see no problem to keep it in my local repo. > I let you decide! Nah, if it’s an easy fix, do a PR (In reply to laurantino from comment #6) > Good question ! ;-) > i am just patching it as proxy maintainer but I am not using it very often > and do not know if there are people using it. You are using it. That's enough for us. Please make the fix available for anyone else who might use it, do a good deed for the community ;) No problem! I am actually waiting for an answer from Jonas Stein, because all ffdiaporama patches atre stored in his gentoo dev space. But as the patch is very small, maybe I can just add it to filesdir if it is ok to have a mix of distdir and filesdir for patches ? (In reply to laurantino from comment #9) > No problem! > I am actually waiting for an answer from Jonas Stein, because all > ffdiaporama patches atre stored in his gentoo dev space. But as the patch is > very small, maybe I can just add it to filesdir if it is ok to have a mix of > distdir and filesdir for patches ? The limit for filesdir files is 20 kb - you can put it in there if it's 20 kb or lower. You can also host them in your own Github / Gitlab, and add to SRC_URI. You most likely can also download the upstream commit / PR .patch file directly. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=76c303fed8e00caf287d4dcb86ca53be19f7a24f commit 76c303fed8e00caf287d4dcb86ca53be19f7a24f Author: Olivier Laurantin <olivier.laurantin@laposte.net> AuthorDate: 2021-04-16 13:22:56 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-04-28 06:42:01 +0000 media-video/ffdiaporama: ffmpeg-4.4 compatibility Add a patch for ffmpeg-4.4 compatibility Move patches to proxy maintainer github Closes: https://bugs.gentoo.org/782412 Signed-off-by: Olivier Laurantin <olivier.laurantin@laposte.net> Package-Manager: Portage-3.0.17, Repoman-3.0.2 Closes: https://github.com/gentoo/gentoo/pull/20408 Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-video/ffdiaporama/Manifest | 1 + media-video/ffdiaporama/ffdiaporama-2.2_pre20140701-r2.ebuild | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) |
