Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 781626

Summary: [guru] sys-cluster/kronosnet-1.19 uses -Werror for build
Product: GURU Reporter: Agostino Sarubbo <ago>
Component: Package issuesAssignee: Gentoo Cluster Team <cluster>
Status: RESOLVED FIXED    
Severity: normal CC: esigra, guru-bugs
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/24841
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 785607    

Description Agostino Sarubbo gentoo-dev 2021-04-09 06:33:47 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-cluster/kronosnet-1.19 uses -Werror for build.
Discovered on: amd64 (internal ref: guru_tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Agostino Sarubbo gentoo-dev 2021-04-22 17:02:44 UTC
Changing the Assignee as per https://archives.gentoo.org/gentoo-dev/message/74ee632e9fe2f4c12890524fec132205
Comment 2 Agostino Sarubbo gentoo-dev 2021-04-25 14:03:25 UTC
Changing TRACKER as requested by QA.
Comment 3 Larry the Git Cow gentoo-dev 2022-06-01 00:32:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b4ec8c54b1a4fab045c0e26c565465de9e2d0c05

commit b4ec8c54b1a4fab045c0e26c565465de9e2d0c05
Author:     Alessandro Barbieri <lssndrbarbieri@gmail.com>
AuthorDate: 2022-03-31 23:31:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-01 00:17:37 +0000

    sys-cluster/kronosnet: remove -Werror
    
    Closes: https://bugs.gentoo.org/781626
    Closes: https://bugs.gentoo.org/750548
    Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/24841
    Signed-off-by: Sam James <sam@gentoo.org>

 .../kronosnet/files/kronosnet-1.19-no-Werror.patch | 11 +++++
 sys-cluster/kronosnet/kronosnet-1.19-r1.ebuild     | 57 ++++++++++++++++++++++
 2 files changed, 68 insertions(+)