Summary: | sys-kernel/dracut-crypt-ssh-1.0.7 is broken with --as-needed ld flag | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexander Zubkov <zubkov318> |
Component: | Current packages | Assignee: | Jakov Smolić <jsmolic> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, proxy-maint |
Priority: | Normal | Keywords: | PATCH, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/20355 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 129413 | ||
Attachments: | proposed patch |
Someone have already reported it to the upstream, but upstream is not maintained currently: https://github.com/dracut-crypt-ssh/dracut-crypt-ssh/pull/44 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=69b9449877745ccd238def39c498b53f60f22c1c commit 69b9449877745ccd238def39c498b53f60f22c1c Author: Jakov Smolic <jakov.smolic@sartura.hr> AuthorDate: 2021-04-12 20:02:39 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-04-14 06:25:43 +0000 sys-kernel/dracut-crypt-ssh: Fix building with --as-needed Closes: https://bugs.gentoo.org/781125 Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr> Closes: https://github.com/gentoo/gentoo/pull/20355 Signed-off-by: Joonas Niilola <juippis@gentoo.org> sys-kernel/dracut-crypt-ssh/dracut-crypt-ssh-1.0.7.ebuild | 2 +- ...t-ssh-1.0.7-ldflags.patch => dracut-crypt-ssh-1.0.7-makefile.patch} | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) |
Created attachment 698580 [details, diff] proposed patch sys-kernel/dracut-crypt-ssh-1.0.7 does not compile when --as-needed ld flag is used. It is because of bad parameters order: -lblkid should be after object files. I have attached the patch to fix it. There is already a patch that modifies the corresponding Makefile in files for the ebuild. The proposed patch modifies that patch - switches positions of "$^" and "-lblkid".