Summary: | net-misc/remmina-1.4.13 makes wayland mandatory | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Attila Tóth <atoth> |
Component: | Current packages | Assignee: | Ben Kohler <bkohler> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bkohler, ionen |
Priority: | Normal | Keywords: | EBUILD, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://gitlab.com/Remmina/Remmina/-/issues/2469 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=779436 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
remmina-1.4.13-r2.ebuild
remmina-1.4.13-wayland-non-mandatory.patch |
Description
Attila Tóth
2021-04-07 07:14:48 UTC
Created attachment 698160 [details]
remmina-1.4.13-r2.ebuild
Proposed remmina ebuild makes wayland optional introducing it as a use flag.
Created attachment 698163 [details, diff]
remmina-1.4.13-wayland-non-mandatory.patch
Proposed patch used by the ebuild.
I see this patch was applied upstream, but... is it an automagic dep now or is it able to be forcibly enabled/disabled with a -D option? It's looking to me like the build system now checks for wayland but doesn't care if it's there or not, and doesn't actually use it at build time in either case. Can you confirm that? The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cdf88b261c1bae48e44418dbf72936161f5c8650 commit cdf88b261c1bae48e44418dbf72936161f5c8650 Author: Ben Kohler <bkohler@gentoo.org> AuthorDate: 2021-07-09 14:33:29 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2021-07-09 14:33:59 +0000 net-misc/remmina: remove (seemingly) unneeded wayland dep Remmina checks for wayland during configure but doesn't seem to care whether it's present or not, and the binaries do not link to wayland in either case. Bug: https://bugs.gentoo.org/780741 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Ben Kohler <bkohler@gentoo.org> net-misc/remmina/remmina-1.4.20.ebuild | 1 - 1 file changed, 1 deletion(-) (In reply to Ben Kohler from comment #4) > It's looking to me like the build system now checks for wayland but doesn't > care if it's there or not, and doesn't actually use it at build time in > either case. > > Can you confirm that? I'm maintaining my own version, that doesn't require wayland as a mandatory dependency, but only if the USE flag is set. |