Bug 779484

Summary:	lxde-base/lxappearance-obconf-0.2.3-r1 - tree.c:(.text+<snip>): undefined reference to lxappearance_changed
Product:	Gentoo Linux	Reporter:	Toralf Förster <toralf>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	orbea
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/26358
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	765709
Attachments:	emerge-info.txt emerge-history.txt environment etc.portage.tar.bz2 logs.tar.bz2 lxde-base:lxappearance-obconf-0.2.3-r1:20210331-031804.log temp.tar.bz2

Description Toralf Förster gentoo-dev

2021-03-31 07:31:31 UTC

/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: src/.libs/src_obconf_la-tree.o: in function `tree_set_string':
tree.c:(.text+0x3ea): undefined reference to `lxappearance_changed'
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: src/.libs/src_obconf_la-tree.o: in function `tree_set_int':
tree.c:(.text+0x433): undefined reference to `lxappearance_changed'
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: src/.libs/src_obconf_la-tree.o: in function `tree_set_bool':

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome_systemd-20210318-090503

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-10.2.0 *
clang version 11.1.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/11/bin
/usr/lib/llvm/11
11.1.0
Python 3.8.8
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby27 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.50.0
  [2]   rust-1.50.0 *
The following VMs are available for generation-2:
1)	IcedTea JDK 3.17.1 [icedtea-8]
2)	IcedTea JDK 3.16.0 [icedtea-bin-8]
3)	OpenJDK 8.282_p08 [openjdk-8]
*)	AdoptOpenJDK 8.282_p08 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-8 
  [2]   icedtea-bin-8 
  [3]   openjdk-8 
  [4]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Tue Mar 30 16:35:56 UTC 2021

emerge -qpvO lxde-base/lxappearance-obconf
[ebuild  N    ] lxde-base/lxappearance-obconf-0.2.3-r1

Comment 1 Toralf Förster gentoo-dev

2021-03-31 07:31:32 UTC

Created attachment 696381 [details]
emerge-info.txt

Comment 2 Toralf Förster gentoo-dev

2021-03-31 07:31:34 UTC

Created attachment 696384 [details]
emerge-history.txt

Comment 3 Toralf Förster gentoo-dev

2021-03-31 07:31:35 UTC

Created attachment 696387 [details]
environment

Comment 4 Toralf Förster gentoo-dev

2021-03-31 07:31:37 UTC

Created attachment 696390 [details]
etc.portage.tar.bz2

Comment 5 Toralf Förster gentoo-dev

2021-03-31 07:31:38 UTC

Created attachment 696393 [details]
logs.tar.bz2

Comment 6 Toralf Förster gentoo-dev

2021-03-31 07:31:39 UTC

Created attachment 696396 [details]
lxde-base:lxappearance-obconf-0.2.3-r1:20210331-031804.log

Comment 7 Toralf Förster gentoo-dev

2021-03-31 07:31:41 UTC

Created attachment 696399 [details]
temp.tar.bz2

Comment 8 orbea 2021-03-31 13:35:52 UTC

No idea where lxappearance_changed(); is supposed to come from, all I see is the header in the lxappearance package.

Comment 9 orbea 2021-03-31 13:40:56 UTC

Actually its in src/lxappearance.c from the lxappearance code, but its only compiled into the lxappearance binary.

Either lxappearance needs to actually create a library for downstream projects to use or downstream projects should not use lxappearance_changed();...

Comment 10 Larry the Git Cow gentoo-dev

2022-07-12 02:06:54 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26734c3900e4e41aa7820b6f4afcf30bec26a441

commit 26734c3900e4e41aa7820b6f4afcf30bec26a441
Author:     orbea <orbea@riseup.net>
AuthorDate: 2022-07-12 00:48:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-12 01:59:31 +0000

    lxde-base/lxappearance-obconf: Fix slibtool build
    
    Also fixes a -Wimplicit-function-declaration for cairo_xlib_surface_create.
    
    Bug: https://bugs.gentoo.org/779484
    Signed-off-by: orbea <orbea@riseup.net>
    Closes: https://github.com/gentoo/gentoo/pull/26358
    Signed-off-by: Sam James <sam@gentoo.org>

 .../lxappearance-obconf-0.2.3-cairo-xlib.patch     | 39 ++++++++++++++
 .../lxappearance-obconf-0.2.3-no-undefined.patch   | 25 +++++++++
 .../lxappearance-obconf-0.2.3-r2.ebuild            | 61 ++++++++++++++++++++++
 3 files changed, 125 insertions(+)