Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 778806

Summary: perl-module.eclass: uses ${D} in perl-module_src_configure
Product: Gentoo Linux Reporter: Sam James <sam>
Component: EclassesAssignee: Gentoo Perl team <perl>
Status: RESOLVED FIXED    
Severity: normal CC: gentoo_bugs_2_peep
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=836052
https://github.com/gentoo/gentoo/pull/36564
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 775191, 836067    

Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-03-27 22:43:54 UTC
See summary.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-26 05:43:05 UTC
ping
Comment 2 Ulrich Müller gentoo-dev 2023-02-09 07:17:56 UTC
I believe this is no longer an issue after the recent update of the PMS section:
https://gitweb.gentoo.org/proj/pms.git/commit/?id=ede65b5d136640575479c9c9a3162ee4d2be953e
Comment 3 Larry the Git Cow gentoo-dev 2024-05-10 17:28:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9be198be536915b3e9f3da57eca25c90d7ca3214

commit 9be198be536915b3e9f3da57eca25c90d7ca3214
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-04 10:24:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-10 17:27:04 +0000

    perl-module.eclass: stop using ${D} for MakeMaker in src_configure
    
    See https://metacpan.org/dist/ExtUtils-MakeMaker/view/lib/ExtUtils/MakeMaker.pm#DESTDIR.
    
    Bug: https://bugs.gentoo.org/778806
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/perl-module.eclass | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9923973f58e7f5af1b1b53d9077b210224fc81b0

commit 9923973f58e7f5af1b1b53d9077b210224fc81b0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-04 10:18:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-10 17:27:04 +0000

    perl-module.eclass: stop using ${D} for Module::Build in src_configure
    
    See https://github.com/Perl-Toolchain-Gang/Module-Build/blob/a2ecdf98c25af7dfc7070280232513e8ccec4986/lib/Module/Build/Cookbook.pm#L122.
    
    Bug: https://bugs.gentoo.org/778806
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/perl-module.eclass | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-10 17:45:58 UTC
(In reply to Ulrich Müller from comment #2)
> I believe this is no longer an issue after the recent update of the PMS
> section:
> https://gitweb.gentoo.org/proj/pms.git/commit/
> ?id=ede65b5d136640575479c9c9a3162ee4d2be953e

Agreed, I think, although we still need to do https://github.com/pkgcore/pkgcheck/issues/516. But this was worth cleaning up anyway for cleanliness.