Bug 778581

Summary:	app-editors/lpe-1.2.6.13 - cmode.c:(.text+<snip>): undefined reference to mode_util_accept_extensions
Product:	Gentoo Linux	Reporter:	Toralf Förster <toralf>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	orbea, sam
Priority:	Normal	Keywords:	PATCH, UPSTREAM
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/AdamMajer/lpe/pull/4
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	765709
Attachments:	emerge-info.txt app-editors:lpe-1.2.6.13:20210327-074229.log emerge-history.txt environment etc.portage.tar.bz2 logs.tar.bz2 temp.tar.bz2 Patch against the upsream 1.2.8 release. Patch against the upstream 1.2.8 release. https://github.com/AdamMajer/lpe/pull/3

Description Toralf Förster gentoo-dev

2021-03-27 08:48:10 UTC

rdlibtool: link: x86_64-pc-linux-gnu-gcc .libs/cmode.o -O2 -pipe -march=native -fno-diagnostics-color -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -shared -fPIC -Wl,--no-undefined -o .libs/cmode.so -Wl,--export-dynamic
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: .libs/cmode.o: in function `mode_accept':
cmode.c:(.text+0x17a2): undefined reference to `mode_util_accept_extensions'
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: cmode.c:(.text+0x17d7): undefined reference to `mode_util_accept_on_request'
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: .libs/cmode.o: in function `mode_init':
cmode.c:(.text+0x1843): undefined reference to `cfg_get_option_int_with_default'

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_hardened-20210316-095736

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-8.3.1
 [3] x86_64-pc-linux-gnu-10.2.0 *
clang version 11.1.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/11/bin
/usr/lib/llvm/11
11.1.0
Python 3.8.8
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby27 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.50.0
  [2]   rust-1.50.0 *
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.282_p08 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Sat Mar 27 06:50:41 UTC 2021

emerge -qpvO app-editors/lpe
[ebuild  N    ] app-editors/lpe-1.2.6.13  USE="nls"

Comment 1 Toralf Förster gentoo-dev

2021-03-27 08:48:11 UTC

Created attachment 694791 [details]
emerge-info.txt

Comment 2 Toralf Förster gentoo-dev

2021-03-27 08:48:12 UTC

Created attachment 694794 [details]
app-editors:lpe-1.2.6.13:20210327-074229.log

Comment 3 Toralf Förster gentoo-dev

2021-03-27 08:48:14 UTC

Created attachment 694797 [details]
emerge-history.txt

Comment 4 Toralf Förster gentoo-dev

2021-03-27 08:48:15 UTC

Created attachment 694800 [details]
environment

Comment 5 Toralf Förster gentoo-dev

2021-03-27 08:48:17 UTC

Created attachment 694803 [details]
etc.portage.tar.bz2

Comment 6 Toralf Förster gentoo-dev

2021-03-27 08:48:18 UTC

Created attachment 694806 [details]
logs.tar.bz2

Comment 7 Toralf Förster gentoo-dev

2021-03-27 08:48:19 UTC

Created attachment 694809 [details]
temp.tar.bz2

Comment 8 orbea 2021-03-30 18:06:24 UTC

Created attachment 696279 [details, diff]
Patch against the upsream 1.2.8 release.

I'm not sure how to best report this to debian yet, but this is another case of -no-undefined. Additionally the build needed to be refactored to make it possible to resolve the undefined references. It still seems to work at runtime.

Comment 9 orbea 2021-03-30 18:19:06 UTC

Created attachment 696282 [details, diff]
Patch against the upstream 1.2.8 release.

I'm not sure how to best report this to debian yet, but this is another case of -no-undefined. Additionally the build needed to be refactored to make it possible to resolve the undefined references. It still seems to work at runtime.

Comment 10 orbea 2021-03-31 16:03:10 UTC

According to debian the upstream is here.

https://github.com/AdamMajer/lpe

And I made a PR.

https://github.com/AdamMajer/lpe/pull/3

Comment 11 orbea 2021-04-01 13:33:02 UTC

Created attachment 696753 [details, diff]
https://github.com/AdamMajer/lpe/pull/3

After talking with upstream it seems the best course is to just remove -no-undefined which does not make much sense in this case. This patch was merged upstream.

The gcc10 patch that gentoo already carries was also merged upstream. :)

Comment 12 Larry the Git Cow gentoo-dev

2021-04-01 22:08:53 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65ed7850a0f6ddd7a55b26665bef21998f0509b7

commit 65ed7850a0f6ddd7a55b26665bef21998f0509b7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-04-01 22:06:10 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-01 22:08:40 +0000

    app-editors/lpe: add 1.2.8_p20210401
    
    Add missing virtual/libintl dep for musl,
    take snapshot for upstream slibtool + gcc 10 (our!)
    fix.
    
    Closes: https://bugs.gentoo.org/778581
    Closes: https://bugs.gentoo.org/713778
    Signed-off-by: Sam James <sam@gentoo.org>

 app-editors/lpe/Manifest                   |  1 +
 app-editors/lpe/lpe-1.2.8_p20210401.ebuild | 63 ++++++++++++++++++++++++++++++
 2 files changed, 64 insertions(+)