Summary: | games-puzzle/enigma-1.30 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Khumba <bog> |
Component: | Current packages | Assignee: | Gentoo Games <games> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
enigma-1.30_alpha.ebuild
Updated build patch Patch adding enigma-1.30-alpha to the gentoo tree enigma-1.30.ebuild enigma-1.30-build.patch enigma-1.30-remove-menu-music.patch License file for pentagonal_dreams.s3m |
Description
Khumba
2021-03-27 03:02:28 UTC
Created attachment 694602 [details]
enigma-1.30_alpha.ebuild
Would you mind attaching it in git format-patch format (with GCO sign off) or a GitHub PR? Created attachment 694605 [details, diff]
Updated build patch
enigma-1.30_alpha-build.patch replaces enigma-1.21-build.patch.
enigma-1.21-gcc6.patch is now upstream and can be dropped.
(In reply to Sam James from comment #2) > Would you mind attaching it in git format-patch format (with GCO sign off) > or a GitHub PR? Sure. Please give me a moment to read up on the process for that :). Created attachment 694812 [details, diff]
Patch adding enigma-1.30-alpha to the gentoo tree
Repackaged with git-format-patch. Compared to the previous upload, there's one QA fix, repoman pointed out that dosym's first argument shouldn't be an absolute path.
Created attachment 860502 [details]
enigma-1.30.ebuild
Created attachment 860503 [details, diff]
enigma-1.30-build.patch
Created attachment 860504 [details, diff]
enigma-1.30-remove-menu-music.patch
Created attachment 860505 [details]
License file for pentagonal_dreams.s3m
Enigma 1.30 released back in 2021. Here is an updated ebuild and related files. Notable changes: - The gettext dependency has been replaced with a bundled copy of tinygettext. I'm not sure how necessary this is for Gentoo's use case, so it might be possible to unbundle, but I haven't attempted this yet. Upstream documents why they bundle it[1]. - One of the Enigma menu music tracks, which also happens to be "the" iconic one, is under a non-libre license that only allows redistribution with Enigma. For this reason, Debian removes this particular track[2]. Personally I think the song is really good, so I've put it's installation behind USE=non-free with a custom license file, but I'm not sure if this is acceptable for Gentoo. If not, let's patch it out unconditionally. - Updated to EAPI 8, without changes. Minor SRC_URI adjustment. Previously a patch for gentoo.git was requested, I'd be happy to do that again if the ebuild looks okay. [1] https://github.com/Enigma-Game/Enigma/blob/1.30/lib-src/tinygettext/README.enigma [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=321669#20 |