Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 777561

Summary: dev-libs/libpmemobj-cpp - C++ bindings for dev-libs/pmdk
Product: Gentoo Linux Reporter: Jan K <jprofesorek>
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: CONFIRMED ---    
Severity: normal CC: chutzpah, jstein
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://github.com/pmem/libpmemobj-cpp
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Proposed ebuild
proposed ebuild file
metadata.xml with use flag description

Description Jan K 2021-03-21 18:30:40 UTC
PMDK (https://github.com/pmem/pmdk, dev-libs/pmdk) is a set of libraries for writing persistent memory aware apps in C.
libpmemobj-cpp (https://github.com/pmem/libpmemobj-cpp) are C++ bindings for the main part of PMDK.

Reproducible: Always
Comment 1 Jan K 2021-03-21 18:31:12 UTC
Created attachment 692811 [details]
Proposed ebuild
Comment 2 Jonas Stein gentoo-dev 2021-03-22 00:22:13 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck scan --net
* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)
* A bot can look for additional mistakes, if you upload a PR via github
* add || die in the rm line
Comment 3 Jan K 2021-03-23 14:58:29 UTC
Created attachment 693243 [details]
proposed ebuild file
Comment 4 Jan K 2021-03-23 14:59:01 UTC
Created attachment 693246 [details]
metadata.xml with use flag description
Comment 5 Jan K 2021-03-23 15:02:38 UTC
Thanks for the pointers, I fixed the ebuild as much as I was able to. If I were to create a pull request, I'd have to add a maintainer to the metadata.xml and I have no idea what to put there.