Summary: | dev-util/babeltrace-1.2.4 multiple definition of `bt_lookup_format' when using rlibtool | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alessandro Barbieri <lssndrbarbieri> |
Component: | Current packages | Assignee: | Yixun Lan <dlan> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ionen, orbea, sam |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/25408 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 765709 | ||
Attachments: | babeltrace-1.2.4:20210321-012018.log |
Description
Alessandro Barbieri
2021-03-21 01:23:14 UTC
Created attachment 692625 [details]
babeltrace-1.2.4:20210321-012018.log
buildlog
babeltrace-1.2.4 is from 2016 and this has been fixed upstream since their v2.0.1 git tag, their most recent tag v2.0.4 also works as does their current git HEAD. Just update babeltrace to fix this. wrt -fno-common blocker note that -fcommon doesn't seem to fix this and it only happens with slibtool, so believe it's mostly something different. These will mention static libraries for the first definition, e.g. trace-handle.c:(.text+0x55): multiple definition of `bt_trace_handle_get_timestamp_begin'; types/.libs/libctf-types.a(trace-handle.o):trace-handle.c:(.text+0x55): first defined here (In reply to Ionen Wolkens from comment #3) > wrt -fno-common blocker note that -fcommon doesn't seem to fix this and it > only happens with slibtool, so believe it's mostly something different. > > These will mention static libraries for the first definition, e.g. > > trace-handle.c:(.text+0x55): multiple definition of > `bt_trace_handle_get_timestamp_begin'; > types/.libs/libctf-types.a(trace-handle.o):trace-handle.c:(.text+0x55): > first defined here Good point! There is little point worrying about it when all this needs is a version bump. (In reply to orbea from comment #5) > There is little point worrying about it when all this needs is a version > bump. Was speaking generally because this isn't the only one, like bug #778248, and it's useful to be able to identify them. This is an overlinking issue where internal .la dependencies are linked repeatedly causing multiple definition errors. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=deaeeee3d4cd6625fcae1301af88e7454581c0e3 commit deaeeee3d4cd6625fcae1301af88e7454581c0e3 Author: orbea <orbea@riseup.net> AuthorDate: 2022-05-09 22:21:15 +0000 Commit: Yixun Lan <dlan@gentoo.org> CommitDate: 2022-05-09 23:13:27 +0000 dev-util/babeltrace: Fix overlinking When building with slibtool the build fails with many multiple definition errors. This is because of overlinking internal .la files where GNU libtool somehow obscures the issue. Note the newer Babeltrace 2 which is not yet in Gentoo does not seem to have any slibtool related build issues. Bug: https://bugs.gentoo.org/777444 Upstream-PR: https://github.com/efficios/babeltrace/pull/119 Closes: https://github.com/gentoo/gentoo/pull/25408 Signed-off-by: orbea <orbea@riseup.net> Signed-off-by: Yixun Lan <dlan@gentoo.org> dev-util/babeltrace/babeltrace-1.5.8.ebuild | 19 +++- .../files/babeltrace-1.5.8-slibtool.patch | 119 +++++++++++++++++++++ 2 files changed, 135 insertions(+), 3 deletions(-) |