Bug 777402 – dev-python/uvicorn: RDEPEND should have dev-python/websockets for net-misc/etebase-server

• Product: Gentoo Linux
• Status: RESOLVED INVALID

[Description Quentin Retornaz 2021-03-20 16:48:16 UTC]

Hello,
I’m maintaining a package net-misc/etebase-server on my overlay.
I see that since I have it on my overlay, uvicorn has been added to ::gentoo.
If I would add etebase-server as a proxy-maint in ::gentoo, dev-python/uvicorn should RDEPEND on dev-python/websockets as it need it.
Maybe could it be added as a USE flag if you wish.

[Comment 1 Quentin Retornaz 2021-03-20 16:53:03 UTC]

and probably also in DEPEND

[Comment 2 Louis Sautier (sbraz) 2021-03-23 21:05:44 UTC]

Hi,
As far as I can tell, websockets is just one of several backends that uvicorn supports. That's why upstream doesn't list it as a mandatory dependency, only h11 is mandatory:
https://github.com/encode/uvicorn/blob/bf1c64e2c141971c546671c7dc91b8ccf0afeb7d/setup.py#L46

A USE flag that doesn't require a rebuild doesn't sound very useful and we don't yet have support for runtime-switchable USE flags. It's probably easiest if you add websockets to your package's RDEPEND.

[Comment 3 Quentin Retornaz 2021-03-23 22:03:01 UTC]

Right, but I heavily think that uvicorn needs it also at build time, else, it does not work

[Comment 4 Quentin Retornaz 2021-03-23 22:40:11 UTC]

Ah maybe not, sorry, you are right.

[Comment 5 Louis Sautier (sbraz) 2021-03-24 21:48:54 UTC]

(In reply to Quentin Retornaz from comment #3)
> Right, but I heavily think that uvicorn needs it also at build time, else,
> it does not work
> Ah maybe not, sorry, you are right.

Just for the test phase, I think. This is why it is only listed there. I spent quite a bit of time checking dependencies for httpx and its revdeps.