Bug 777129 (multiple-KEYWORDS)

Summary:	[Tracker] Packages with multiple KEYWORDS lines defined
Product:	Quality Assurance	Reporter:	Sam James <sam>
Component:	Trackers	Assignee:	Gentoo Quality Assurance Team <qa>
Status:	CONFIRMED ---
Severity:	normal	Keywords:	Tracker
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=639724 https://bugs.gentoo.org/show_bug.cgi?id=562464
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	777132, 777135, 777138, 777141, 790785
Bug Blocks:

Description Sam James archtester

2021-03-19 04:06:40 UTC

KEYWORDS must be defined on exactly one line due to ekeyword (and other tools) which use naive line-based parsing.

This has been a QA policy for some time: https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0105.

I removed most trivial cases in the tree a month ago: https://github.com/gentoo/gentoo/pull/19467.

We still have some left. Fortunately, pkgcheck can now detect this (`pkgcheck scan -k MultipleKeywordsLines`): https://github.com/pkgcore/pkgcheck/issues/303.

If your package has multiple defined, please drop them and define only one (the operational/effective version). Note that PMS says it is safe to not define KEYWORDS in e.g. live ebuilds: https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-620007.3 as it defaults to none.

Comment 1 Paul Zander 2021-03-21 20:28:42 UTC

I'd assume (re-)defining the KEYWORD in an eclass is an extension of this. See bug #562464