Summary: | (toolchain) mjpegtools-1.6.2-r3 fails to build | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Patrick Lauer <patrick> |
Component: | New packages | Assignee: | The Gentoo Linux Hardened Team <hardened> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kevquinn, media-video, praseodym+gentoobugzilla, sirspiritus |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 78404 | ||
Bug Blocks: | |||
Attachments: |
patch that should allow deinterlace.c to build for those with the problem
Same as before, but with #ifdefs to preserve original code on non-pic |
Description
Patrick Lauer
![]() Same issue, also on an athlon, basically the same settings except -march=athlon instead of XP. Tried removing 3dnow - didn't help. Not sure how to fix this, but I can't finish installing :( adding -fno-pie to CFLAGS fixed the problem with me. *** Bug 78680 has been marked as a duplicate of this bug. *** There is some fPIC patch already - maybe another one for fPIE? Weird enough adding "media-video/mjpegtools -pie" to /etc/portage/package.use doesn't work - any ideas? Created attachment 49830 [details, diff]
patch that should allow deinterlace.c to build for those with the problem
This builds fine for me (athlon-xp) with the patch I posted to #78404, but the
trick is simple and may work here too.
I have about 4 deps to update then I'll doa trial run with your patch kevin. I can confirm that mjpegtools compiles with this and the patch from bug #78404 but I'm not sure how to confirm runtime. Perhaps we should wrapper the asm changes in #ifdef __PIC__\n\tNEW_CODE_HERE\n#else\nOLD_CODE_HERE\n#endif Created attachment 49841 [details, diff]
Same as before, but with #ifdefs to preserve original code on non-pic
Just to be safe; avoid potentially breaking it where it already works.
Updated patches, fixing PIC and TEXTRELs in this ebuild, attached to bug #78404 *** Bug 86264 has been marked as a duplicate of this bug. *** media-video herd. Is the proposed patch acceptiable to you now? Will you commit or should hardened? I think this can be marked RESOLVED/FIXED, as bug #78404 has been. patch in mjpegtools-1.6.2-r4 Thank you Daniel Kevin and all others for helping to test. Anybody happen to mail upstream yet? |