Summary: | sys-apps/man-pages: Consider replacing passwd(5) with sys-apps/shadow's version | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Haelwenn (lanodan) Monnier <contact> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ionen, ulm |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/21745 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Haelwenn (lanodan) Monnier
2021-03-17 00:56:37 UTC
IMHO replacing the page in the man-pages package makes little sense. sys-apps/shadow currently has this: # Remove manpages that are handled by other packages find "${ED}"/usr/share/man \ '(' -name id.1 -o -name passwd.5 -o -name getspnam.3 ')' \ -delete Presumably, passwd.5 and getspnam.3 should be removed from that list, and be suppressed in sys-apps/man-pages instead? (id.1 isn't affected because it is installed by coreutils.) If the version in shadow has information that is not included in man-pages, I agree we should use it instead. (In reply to Mike Gilbert from comment #2) > If the version in shadow has information that is not included in man-pages, > I agree we should use it instead. I can prepare an update and post it as a PR for review. @base-system: Do we need testing, or would you prefer this going straight to stable for sys-apps/shadow and/or sys-apps/man-pages? (In reply to Ulrich Müller from comment #3) > (In reply to Mike Gilbert from comment #2) > > If the version in shadow has information that is not included in man-pages, > > I agree we should use it instead. > > I can prepare an update and post it as a PR for review. > > @base-system: Do we need testing, or would you prefer this going straight to > stable for sys-apps/shadow and/or sys-apps/man-pages? I don't think this requires testing. Please review: https://github.com/gentoo/gentoo/pull/21745 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a88fa1a16f579f03e516eb307ecd0be888a85da5 commit a88fa1a16f579f03e516eb307ecd0be888a85da5 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2021-07-22 13:17:31 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2021-07-23 19:20:28 +0000 sys-apps/shadow: Install the passwd.5 man page This needs a somewhat awkward blocker against sys-apps/man-pages, which can be simplified when >=man-pages-5.12-r2 becomes stable. Bug: https://bugs.gentoo.org/776787 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Ulrich Müller <ulm@gentoo.org> sys-apps/shadow/{shadow-4.8.1-r3.ebuild => shadow-4.8.1-r4.ebuild} | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66a1194907411653f87fbf9b1d1b1e3732aeadf5 commit 66a1194907411653f87fbf9b1d1b1e3732aeadf5 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2021-07-22 13:13:50 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2021-07-23 19:20:22 +0000 sys-apps/man-pages: Don't install passwd.5 A more accurate version of it is installed by sys-apps/shadow. Bug: https://bugs.gentoo.org/776787 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Ulrich Müller <ulm@gentoo.org> .../man-pages/{man-pages-5.11.ebuild => man-pages-5.11-r1.ebuild} | 7 +++++++ .../{man-pages-5.12-r1.ebuild => man-pages-5.12-r2.ebuild} | 7 +++++++ 2 files changed, 14 insertions(+) |