Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 774267

Summary: dev-util/umockdev-0.12.1 - /.../libumockdev-preload.c: error: no previous prototype for _xstat [-Werror=missing-prototypes]
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: dennis.lissov, juippis, kajanos, marduk, matthew, sam, skobkin-ru
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 768369    
Attachments: emerge-info.txt
dev-util:umockdev-0.12.1:20210305-065707.log
emerge-history.txt
environment
etc.portage.tar.bz2
logs.tar.bz2
temp.tar.bz2
fix _xstat

Description Toralf Förster gentoo-dev 2021-03-05 08:23:00 UTC
/var/tmp/portage/dev-util/umockdev-0.12.1/work/umockdev-0.12.1/src/libumockdev-preload.c:1321:14: error: no previous prototype for ‘__xstat’ [-Werror=missing-prototypes]
 1321 | WRAP_VERSTAT(__x,);
      |              ^~~
/var/tmp/portage/dev-util/umockdev-0.12.1/work/umockdev-0.12.1/src/libumockdev-preload.c:1186:5: note: in definition of macro ‘WRAP_VERSTAT’

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-20210227-144317

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10.2.0 *
clang version 11.1.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/11/bin
/usr/lib/llvm/11
11.1.0
Python 3.8.8
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby27 (with Rubygems)
  [3]   ruby30 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.50.0 *
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.282_p08 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.8.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Fri Mar  5 06:22:09 UTC 2021

emerge -qpvO dev-util/umockdev
[ebuild  N    ] dev-util/umockdev-0.12.1  USE="introspection -static-libs -test" ABI_X86="(64) -32 (-x32)"
Comment 1 Toralf Förster gentoo-dev 2021-03-05 08:23:01 UTC
Created attachment 689418 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-03-05 08:23:02 UTC
Created attachment 689421 [details]
dev-util:umockdev-0.12.1:20210305-065707.log
Comment 3 Toralf Förster gentoo-dev 2021-03-05 08:23:04 UTC
Created attachment 689424 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2021-03-05 08:23:06 UTC
Created attachment 689427 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2021-03-05 08:23:07 UTC
Created attachment 689430 [details]
etc.portage.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2021-03-05 08:23:08 UTC
Created attachment 689433 [details]
logs.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2021-03-05 08:23:09 UTC
Created attachment 689436 [details]
temp.tar.bz2
Comment 8 Michal Jakubowski 2021-04-06 22:18:23 UTC
Any update ?
Comment 9 Pavol Cvengros 2021-04-07 09:06:42 UTC
see patch attached from upstream git/bug
put it in /etc/portage/patches/dev-util/umockdev-0.12.1
Comment 10 Pavol Cvengros 2021-04-07 09:07:13 UTC
Created attachment 698172 [details, diff]
fix _xstat
Comment 11 Michal Jakubowski 2021-04-07 09:19:58 UTC
(In reply to Pavol Cvengros from comment #10)
> Created attachment 698172 [details, diff] [details, diff]
> fix _xstat

Thx, it looks fine to me.
Comment 12 Matt Turner gentoo-dev 2021-04-08 02:23:03 UTC
(In reply to Michal Jakubowski from comment #8)
> Any update ?

If there were updates, we would have posted them here. Please do not do this.
Comment 13 Michal Jakubowski 2021-04-08 08:09:29 UTC
(In reply to Matt Turner from comment #12)
> (In reply to Michal Jakubowski from comment #8)
> > Any update ?
> 
> If there were updates, we would have posted them here. Please do not do this.

the bug lay for a month without updating so someone might have thought it was out of date.
Comment 14 Matt Turner gentoo-dev 2021-04-08 14:53:56 UTC
(In reply to Michal Jakubowski from comment #13)
> (In reply to Matt Turner from comment #12)
> > (In reply to Michal Jakubowski from comment #8)
> > > Any update ?
> > 
> > If there were updates, we would have posted them here. Please do not do this.
> 
> the bug lay for a month without updating so someone might have thought it
> was out of date.

There are thousands of bugs that haven't been updated in more than a month. Take a look at the right column of https://qa-reports.gentoo.org/
Comment 15 Agostino Sarubbo gentoo-dev 2021-04-19 17:57:39 UTC
*** Bug 784167 has been marked as a duplicate of this bug. ***
Comment 16 Nick Andrade 2021-04-26 22:28:53 UTC
Upstream patch referenced above and attached to this ticket resolved the issue for me (with sys-libs/glibc-2.33:2.2 on ~amd64).
Comment 17 Larry the Git Cow gentoo-dev 2021-07-27 00:50:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74b3fb71af8fd929503cd51c76b9d51ba361776f

commit 74b3fb71af8fd929503cd51c76b9d51ba361776f
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2021-07-27 00:48:47 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2021-07-27 00:49:51 +0000

    dev-util/umockdev: Apply patch to fix glibc-2.33 compatibility
    
    Closes: https://bugs.gentoo.org/774267
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 ...lare-__xstat-prototypes-for-glibc-2.32.90.patch | 42 ++++++++++++++++++++++
 dev-util/umockdev/umockdev-0.12.1.ebuild           |  4 +++
 2 files changed, 46 insertions(+)
Comment 18 Matt Turner gentoo-dev 2021-07-27 00:57:11 UTC
So this bug was kind of a mess. No one experiencing it thought to mention that it was related to glibc-2.33. And, while it's great to attach a patch that fixes it, package maintainers are typically not in a position to judge the quality of the fix, so we like to see the patch in an upstream repo. A link to https://github.com/martinpitt/umockdev/commit/f1b416400479d861deffb4c5a40422dcdf190e85 would have been a lot better.