Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 774162

Summary: gui-apps/swappy-1.3.1 uses -Werror for build
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Emily Mills <emily>
Status: RESOLVED FIXED    
Severity: normal CC: gentoo, proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/19762
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 260867    

Description Agostino Sarubbo gentoo-dev 2021-03-04 09:20:23 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: gui-apps/swappy-1.3.1 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Larry the Git Cow gentoo-dev 2021-03-04 12:26:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c638628292d79e6a7612434e5e1caabcba13ef46

commit c638628292d79e6a7612434e5e1caabcba13ef46
Author:     Aisha Tammy <gentoo@aisha.cc>
AuthorDate: 2021-03-04 11:17:18 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-03-04 12:26:08 +0000

    gui-apps/swappy: fix werror for meson build
    
    Closes: https://bugs.gentoo.org/774162
    Package-Manager: Portage-3.0.16, Repoman-3.0.2
    Signed-off-by: Aisha Tammy <gentoo@aisha.cc>
    Closes: https://github.com/gentoo/gentoo/pull/19762
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 gui-apps/swappy/swappy-1.3.1.ebuild | 8 ++++++++
 gui-apps/swappy/swappy-9999.ebuild  | 8 ++++++++
 2 files changed, 16 insertions(+)