Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 7738

Summary: /etc/init.d/checkfs is dependant on modules
Product: Gentoo Linux Reporter: Wout Mertens (RETIRED) <wmertens>
Component: [OLD] Core systemAssignee: Martin Schlemmer (RETIRED) <azarah>
Severity: normal CC: Klaus.Kusche
Priority: High    
Version: 1.0   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---

Description Wout Mertens (RETIRED) gentoo-dev 2002-09-10 04:44:28 UTC
Checkfs should depend on modules since they should be loaded to support the  
devices on which the filesystems are. If you think that's esotheric, it 
happened to me :) 
This is the patch: 
 depend() { 
-       need checkroot 
+       need checkroot modules 
 start() { 
Not too much :)
Comment 1 Martin Schlemmer (RETIRED) gentoo-dev 2002-09-11 13:14:42 UTC
If it test ok, and dont bork anything else, sound logical enouth to do.
As round for testers, and if its fine with a few guys, give me the thumbs

I know it sounds bit silly, but usually the -r? update on baselayout was
due to a very small change that did not seem that important.
Comment 2 Tobias Eichert 2002-09-12 18:26:21 UTC
Hm, modifying this breaks all of my current startup scripts. Dunno why but
nothing won't work anymore. I don't even have the possibility to login as root. 
The last exit was a hard reset of my box...
Comment 3 Wout Mertens (RETIRED) gentoo-dev 2002-09-13 02:21:43 UTC
Ok, that's strange... It works perfectly for me :-/

Are you sure that it's related to this and not the crash?

What's the last startup step you see on the console? Or does it seem to work all
the way but then you can't login?
Comment 4 Martin Schlemmer (RETIRED) gentoo-dev 2002-09-29 12:22:44 UTC
This works fine this side.
Comment 5 Klaus Kusche 2002-10-28 13:36:34 UTC
The new checkfs from baselayout with checkfs now depending on modules
breaks my system startup:

I have a static kernel without module support and without any module
infrastructure installed. As far as I can tell, on startup, "modules" isn't
started properly, "checkfs" isn't executed because one of its dependencies is
missing, and anything depending on "checkfs" is not executed for the same reason.

Removing "modules" from the depends of "checkfs" makes everything working again.

However, I'm not yet sure what *exactly* causes the problem, because "modules"
*is* executed before "checkfs" (I do have "modules" in /etc/runlevels/boot), and
it *is* registered as started in /mnt/.init.d/started.

It just returns immediately because its first line is "[ -f /proc/modules ] ||
return", and a kernel built without module support doesn't have /proc/modules.

Why does this cause troubles with "checkfs"?
Comment 7 Martin Schlemmer (RETIRED) gentoo-dev 2002-10-29 11:49:49 UTC
Try to change it to:

  "[ -f /proc/modules ] || return 0"

And see if that fixes it ?  Sometimes not specifying what to
return can have unpredictable results.

Comment 8 Klaus Kusche 2002-10-29 12:15:57 UTC
"return 0" solves the problem for me:

My system boots fine now with a kernel without module support, even if "checkfs"
depends on "modules".
Comment 9 Martin Schlemmer (RETIRED) gentoo-dev 2002-10-29 14:46:38 UTC
Fixed in CVS, thanks.
Comment 10 Martin Schlemmer (RETIRED) gentoo-dev 2002-12-25 14:05:07 UTC
The baselayout containing this fix is already in portage.