Summary: | dev-util/colm-0.14.7-r1 calls cc directly | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 243502 | ||
Attachments: | build.log |
Description
Agostino Sarubbo
2021-02-21 09:16:23 UTC
Created attachment 687831 [details]
build.log
build log and emerge --info
Possible context of error(s): sh: line 1: gcc: command not found error: colm: there was a problem compiling the output While i checked for a different issue (ignoring *FLAGS), i found the issue for this one too: the package creates a binary src/.libs/colm which has a fixed call "gcc -Wall..." to compile certain parts. The gcc call can be found inside src/main.cc where "gcc -Wall" should both get a replacement for "gcc" (might require another sed call in the ebuild) and also get a "${CFLAGS}" added to the arguments. ci has reproduced this issue with version 0.14.7-r1 - Updating summary. See also: commit 702512674608c58428dbc6b2033ad11780bcffbb Author: Sam James <sam@gentoo.org> Date: Tue Jan 19 14:46:45 2021 +0000 dev-util/colm: respect CC, CXX Package-Manager: Portage-3.0.13, Repoman-3.0.2 Signed-off-by: Sam James <sam@gentoo.org> (Doesn't fix the issue with hard-coded define though, just linking to a relevant old commit.) This is properly fixed upstream in https://github.com/adrian-thurston/colm/commit/bb487b1368b65a1f30fe3a59fd0c7d84bdcc483b. (In reply to Sam James from comment #6) > This is properly fixed upstream in > https://github.com/adrian-thurston/colm/commit/ > bb487b1368b65a1f30fe3a59fd0c7d84bdcc483b. Requested a new release at https://github.com/adrian-thurston/colm/issues/150. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ed80e7fbd76241d440fe0bcd84d8723f93b8d73 commit 4ed80e7fbd76241d440fe0bcd84d8723f93b8d73 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-09-14 00:20:37 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-09-14 00:20:37 +0000 dev-util/colm: respect CC Fixes build on pure Clang systems. There's a proper upstream fix [0] but it's too awkward to backport with our other patches and there's been a lot of other changes relating to our patches upstream anyway. Have asked for a new release. [0] https://github.com/adrian-thurston/colm/commit/bb487b1368b65a1f30fe3a59fd0c7d84bdcc483b. Closes: https://bugs.gentoo.org/771849 Signed-off-by: Sam James <sam@gentoo.org> dev-util/colm/colm-0.14.7-r1.ebuild | 1 + 1 file changed, 1 insertion(+) Should -r1 be stabilized to match the base release then? As it stands, without ~amd64 keyword accepting this package as an override, colm does not build on llvm-musl systems, which becomes a blocker for dev-util/ragel-7.0.4, dev-ruby/json-2.5.1-r1, and eventually dev-lang/ruby:3.0 |