Summary: | gentoo-sources-2.4.28-r[457] "modules" target does not compile | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | John Altstadt <altstadt> |
Component: | [OLD] Core system | Assignee: | Tim Yamin (RETIRED) <plasmaroo> |
Status: | VERIFIED FIXED | ||
Severity: | major | CC: | vericgar |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | log from the kernel build |
Description
John Altstadt
2005-01-08 15:36:25 UTC
Created attachment 47998 [details]
log from the kernel build
If you add #include <linux/module.h> to net/decnet/dn_neigh.c does that fix the issue? Yes, it does fix the problem. Oddly enough, there are many other files that have similar source code, i.e. use THIS_MODULE but do not include <linux/module.h>. Perhaps they include the file through another .h file. To see a list of these files, run this command from the linux-2.4.28-gentoo-r4 directory: grep -L 'linux\/module\.h' `grep -rl THIS_MODULE *` | egrep -v '(\.o|\.h)' Oops. Sorry if I was a bit obtuse there. The problem has been completely fixed by the addition of the single line of code. On two different machines even. They are both happily running with the new kernel. My further comments were just implying that I don't understand why the build worked now, because there are plenty of other files that use the same identifier without explicitly including the definition. I have searched the new log files and they only contain the string "error" (in any mix of case) inside comment strings, file names, and compiler directives. The same problem exists for gentoo-sources-2.4.28-r5 and the same solution fixes it. *** Bug 78611 has been marked as a duplicate of this bug. *** this isn't a genkernel bug, tryed to compile without genkernel and had the same problem Fixed in 2.4.28-r6; thanks! Sorry to be the bearer of bad news, but the last emerge sync didn't download 2.4.28-r6. Instead it delivered 2.4.28-r7, which is missing the line: ${FILESDIR}/${PN}-2.4.28.77181.patch from UNIPATCH_LIST. I added this line back in and now everything builds properly. Oops, fixed now. Thanks; sorry that I forgot to add that in. Verified that the build works. Thanks. |