Summary: | sys-devel/patch: patch reports uncorrect failures with --dry-run | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Guillaume Destuynder (RETIRED) <kang> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED UPSTREAM | ||
Severity: | blocker | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://dev.gentoo.org/~kang/rsbac/patch.txt | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
just the bad hunk
the whole patch |
Description
Guillaume Destuynder (RETIRED)
2005-01-08 05:50:05 UTC
According to metadata.xml, assigning to base-system herd. try cutting the patch file down to the 1 problematic hunk ... if it still fails with just that 1 hunk, attach it here along with the file it applies against It works if i split hunks while this is a work around, shouldn't this still be a bug ? ever experienced it ? I did a few more tests... if i put any other hunk with the failing one, dry-run *never* works if its alone it does indeed work i didnt tell you to fix your patch, i told you to attach the problematic files here so i could test :P ... if it still fails with just that 1 hunk, attach it here along with the file it applies against ... I see a IF so yes, you did tell me that ;) Sorry for the delay, my ISP was down for longer than a week :( Created attachment 48872 [details, diff]
just the bad hunk
Created attachment 48873 [details, diff]
the whole patch
Ok, I finally got the explanation why it's like that: < ferringb> so... like I said, later hunk relying on an earlier patch, something dry-run doesn't pick up on (nor is it easy to implement, long standing issue with patch actually) And I didn't know. The bug is probably invalid. (I let you mark it so) Sorry :) sounds good ;) |