Bug 771216

Summary:	sys-kernel/gentoo-kernel-5.10.16, sys-kernel/vanilla-kernel-5.10.17 uses -Werror for build
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Distribution Kernel Project <dist-kernel>
Status:	CONFIRMED ---
Severity:	normal	CC:	bertrand, esigra, mgorny
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867

Description Agostino Sarubbo gentoo-dev

2021-02-18 07:40:36 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-kernel/gentoo-kernel-5.10.16 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Michał Górny archtester

2021-02-18 09:24:18 UTC

*** Bug 771219 has been marked as a duplicate of this bug. ***

Comment 2 Georgy Yakovlev archtester

2021-05-27 22:15:56 UTC

*** Bug 776853 has been marked as a duplicate of this bug. ***

Comment 3 Georgy Yakovlev archtester

2021-05-27 22:19:13 UTC

kernel uses -Werror for some subsystems.

Sometimes there's even a kernel option (disabled by default) to skip -Werror
but we actually want the code to fail on warnings.

can I ask to add sys-kernel/vanilla-kernel and sys-kernel/gentoo-kernel to some kind of -Werror exclude list on CI?

this is one of the rare cases where we'll keep -Werror.

Comment 4 Georgy Yakovlev archtester

2021-05-27 22:20:33 UTC

on ppc it's:

 zcat /proc/config.gz | grep -i werror
# CONFIG_PPC_DISABLE_WERROR is not set
CONFIG_PPC_WERROR=y

Comment 5 Mikle Kolyada archtester

2021-05-28 08:38:44 UTC

(In reply to Georgy Yakovlev from comment #4)
> on ppc it's:
> 
>  zcat /proc/config.gz | grep -i werror
> # CONFIG_PPC_DISABLE_WERROR is not set
> CONFIG_PPC_WERROR=y

x86_64 does not have it (nor similar)

Comment 6 Georgy Yakovlev archtester

2021-05-28 23:18:41 UTC

anyway, point was that we wan -Werror for kernel.

Comment 7 Sam James archtester

2022-06-11 06:19:37 UTC

I'm not convinced we do actually want -Werror. It's useful for finding bugs via CI, it's not useful as a user if something breaks. It's a big waste of time.