Bug 770943

Summary:	sys-apps/ethq-0.6.1 uses -Werror for build
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Vladimir Pavljuchenkov (SpiderX) <spiderx>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dan, esigra, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/19561
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867

Description Agostino Sarubbo gentoo-dev

2021-02-16 13:28:10 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/ethq-0.6.1 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Larry the Git Cow gentoo-dev

2022-06-11 05:48:10 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6159690ee96fdf2dc3473f5de08ac8e361dc8804

commit 6159690ee96fdf2dc3473f5de08ac8e361dc8804
Author:     Vladimir Pavljuchenkov (SpiderX) <spiderx@spiderx.dp.ua>
AuthorDate: 2021-02-20 16:17:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-11 05:48:02 +0000

    sys-apps/ethq: wrt 770943
    
    Closes: https://bugs.gentoo.org/770943
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Vladimir Pavljuchenkov <spiderx@spiderx.dp.ua>
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/ethq/ethq-0.6.1-r1.ebuild | 56 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=57dc9f52aa59e0f9430aa7a46579190f316ee9e2

commit 57dc9f52aa59e0f9430aa7a46579190f316ee9e2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-11 05:43:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-11 05:48:03 +0000

    sys-apps/ethq: don't revbump for Werror fix
    
    Bug: https://bugs.gentoo.org/770943
    See: https://github.com/gentoo/gentoo/pull/19561
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/ethq/ethq-0.6.1-r1.ebuild | 56 --------------------------------------
 sys-apps/ethq/ethq-0.6.1.ebuild    | 10 +++----
 sys-apps/ethq/ethq-9999.ebuild     |  4 +--
 3 files changed, 7 insertions(+), 63 deletions(-)