Bug 769794

Summary:	net-misc/tigervnc-1.11.0-r2 does not install java viewer
Product:	Gentoo Linux	Reporter:	Erik Wallin <erikw>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jstein, sam
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to that restores java viewer installation

Description Erik Wallin 2021-02-09 19:17:05 UTC

The java viewer is no longer installed. It builds, but there is no install target for it.

This was removed upstream. The reason for removal was that java applets do not work with modern browsers.

However the java viewer is still useful if run directly using java -jar.

The java viewer has one advantage over the c++ viewer. It can do screen scaling. So, in my opinion it is worth keeping.

java/CMakeLists.txt was modified in the following commit:

https://github.com/TigerVNC/tigervnc/commit/4a4453fc69cf56f9991a13a62023969dcf5b8a4f#diff-31ed790e942fadafe334a13765d2379b7b89b1c3d65a3973a94d55a77624c5db

I doubt that upstream will restore it. It is really up to distribution to choose what to install.

We could of course notify upstream and see if they want to restore it. Until then there is documentation for how to restore the java client in case someone needs it.

Reproducible: Always

Steps to Reproduce:
Upgrade from 1.9. /usr/share/vnc/classes/VncViewer.jar is built, but no longer installed.



I'm attaching a patch to restore the correct install behaviour.

Comment 1 Erik Wallin 2021-02-09 19:19:46 UTC

Created attachment 686205 [details, diff]
Patch to that restores java viewer installation

This will restore the behaviour of 1.9 where the java viewer was installed along with a README.

Comment 2 Larry the Git Cow gentoo-dev

2021-09-17 02:34:00 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b32857aad326b3f495f80c1e529f940ffb4cff0

commit 5b32857aad326b3f495f80c1e529f940ffb4cff0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-09-17 02:14:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-09-17 02:14:24 +0000

    net-misc/tigervnc: restore Java viewer in 1.11.x
    
    Thanks-to: Erik Wallin <erikw@sizeit.se>
    Closes: https://bugs.gentoo.org/769794
    Signed-off-by: Sam James <sam@gentoo.org>

 .../tigervnc-1.11.0-install-java-viewer.patch      | 26 ++++++++++++++++++++++
 ...-1.11.0-r3.ebuild => tigervnc-1.11.0-r4.ebuild} |  5 +++++
 2 files changed, 31 insertions(+)