Bug 768282 – media-sound/aqualung-1.1-r101 fails to build without lua

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Laszlo Valko 2021-02-01 23:47:39 UTC]

Since slotted lua has been stabilized (https://bugs.gentoo.org/766528), building aqualung insists a supported lua is available, even when using -lua flag to completely skip building against lua.

Reproducible: Always

Steps to Reproduce:
1. remove lua 5.2 if present
2. try to build aqualung with use flag -lua
3.
Actual Results:  
Build fails:

 * aqualung-1.1.tar.gz BLAKE2B SHA512 size ;-) ...                       [ ok ]
 * No Lua implementation selected for the build. Please set
 * the LUA_SINGLE_TARGET variable in your make.conf to one
 * of the following values:
 * 
 * lua5-2


Expected Results:  
Build should simply skip lua and go on building aqualung without any lua whatsoever.

[Comment 1 Laszlo Valko 2021-02-01 23:51:52 UTC]

Created attachment 685476 [details]
emerge --info

[Comment 2 Laszlo Valko 2021-02-01 23:54:20 UTC]

Created attachment 685479 [details]
aqualung-1.1-r1.build.log

Successful build of media-sound/aqualung-1.1-r1 before slotted lua

[Comment 3 Laszlo Valko 2021-02-01 23:55:43 UTC]

Created attachment 685482 [details]
aqualung-1.1-r101.build.log

Unsuccessful build of aqualung-1.1-r101 after slotted lua

[Comment 4 Ionen Wolkens 2021-02-02 00:03:46 UTC]

Created attachment 685485 [details, diff]
conditional lua-single_pkg_setup.patch

[Comment 5 Laszlo Valko 2021-02-02 00:49:09 UTC]

(In reply to Ionen Wolkens from comment #4)
> Created attachment 685485 [details, diff] [details, diff]
> conditional lua-single_pkg_setup.patch

Patch tested and solves my issue.

[Comment 6 Daniel Pielmeier 2021-02-02 06:10:26 UTC]

Conky still needs lua unconditionally. The conky configuration uses lua. In the old version there was no use flag. So the issue came with the migration to slotted lua. I doubt conky will build without lua being present.

The real bug is that there should not be a use flag for the new slotted configuration.

In the meantime USE=lua".

[Comment 7 Laszlo Valko 2021-02-02 08:54:29 UTC]

(In reply to Daniel Pielmeier from comment #6)
> Conky still needs lua unconditionally. The conky configuration uses lua. In
> the old version there was no use flag. So the issue came with the migration
> to slotted lua. I doubt conky will build without lua being present.
> 
> The real bug is that there should not be a use flag for the new slotted
> configuration.
> 
> In the meantime USE=lua".

You must be mixing up something.

media-sound/aqualung/aqualung-1.0.ebuild in 2015 was committed by you with this line in it:
"lua? ( dev-lang/lua:0= )"

So was aqualung-1.0-r5.ebuild and aqualung-1.1.ebuild.

My machines never had this flag turned on, and lua 5.2 has never been installed on them. Obviously, I have never used conky, yet aqualung was still functioning perfectly for me.

So no: the bug is that now aqualung does not build without exactly lua 5.2.

The bug wouldn't have emerged for me if LUA_COMPAT wasn't so picky, btw.

[Comment 8 Daniel Pielmeier 2021-02-02 10:25:02 UTC]

(In reply to Laszlo Valko from comment #7)
> (In reply to Daniel Pielmeier from comment #6)
> > Conky still needs lua unconditionally. The conky configuration uses lua. In
> > the old version there was no use flag. So the issue came with the migration
> > to slotted lua. I doubt conky will build without lua being present.
> > 
> > The real bug is that there should not be a use flag for the new slotted
> > configuration.
> > 
> > In the meantime USE=lua".
> 
> You must be mixing up something.
> 
> media-sound/aqualung/aqualung-1.0.ebuild in 2015 was committed by you with
> this line in it:
> "lua? ( dev-lang/lua:0= )"
> 
> So was aqualung-1.0-r5.ebuild and aqualung-1.1.ebuild.
> 
> My machines never had this flag turned on, and lua 5.2 has never been
> installed on them. Obviously, I have never used conky, yet aqualung was
> still functioning perfectly for me.
> 
> So no: the bug is that now aqualung does not build without exactly lua 5.2.
> 
> The bug wouldn't have emerged for me if LUA_COMPAT wasn't so picky, btw.

Obviously as you see I was talking about conky and not aqualung. So forget my previous post. The patch Ionen Wolkens provided should do the trick just need to test it. Sorry for the confusion.

I added lua-single_pkg_setup to the conky ebuild unconditionally but forgot to add it conditionally for aqualung.

[Comment 9 Larry the Git Cow 2021-02-02 15:29:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f90e48894994971835b76ced8e8d54a3919a92e5

commit f90e48894994971835b76ced8e8d54a3919a92e5
Author:     Daniel Pielmeier <[e-mail]>
AuthorDate: 2021-02-02 15:28:17 +0000
Commit:     Daniel Pielmeier <[e-mail]>
CommitDate: 2021-02-02 15:28:56 +0000

    media-sound/aqualung: Fix bug #768282.
    
    Thanks to Laszlo Valko for the report and Ionen Wolkens for
    the patch.
    
    Closes: https://bugs.gentoo.org/768282
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Daniel Pielmeier <[e-mail]>

 media-sound/aqualung/aqualung-1.1-r101.ebuild | 4 ++++
 1 file changed, 4 insertions(+)