Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 767997

Summary: www-client/firefox: Add X as an optional flag
Product: Gentoo Linux Reporter: fee1-dead-beef
Component: Current packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: RESOLVED FIXED    
Severity: normal CC: ionen, kirill
Priority: Normal Keywords: PullRequest, UPSTREAM
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugzilla.mozilla.org/show_bug.cgi?id=1661450
https://github.com/gentoo/gentoo/pull/27512
Whiteboard:
Package list:
Runtime testing required: ---

Description fee1-dead-beef 2021-01-30 14:53:05 UTC
Introducing the "X" use flag to firefox, so it will able to build without X dependencies.

To make it work, the ebuild should apply patches from the upstream bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1661450

before it is implemented upstream.
Comment 1 Ionen Wolkens gentoo-dev 2021-01-30 15:20:22 UTC
Personally feel it would be better to wait for upstream to include it in a future release rather than add here.

The semi-related upcoming NPAPI code cleanup will remove the need to depend on gtk2 as well.
Comment 2 fee1-dead-beef 2021-01-30 15:41:26 UTC
looks like it has been (partially) implemented upstream: 
https://phabricator.services.mozilla.com/D88797

I will do some testing and see if it works. Maybe a temporary implementation could be made in the live ebuild?
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2021-01-30 15:48:18 UTC
It's not that easy like it sounds.

Even if we ignore the maintenance burden of such a custom patch, LTO/PGO will require virtualx because we have nothing similar for wayland yet. Therefore it's not worth to spend time on this yet from my POV.
Comment 4 Kirill A. Shutemov 2022-09-25 09:55:38 UTC
Looks like it is possible to build firefox without X now.
Comment 5 Larry the Git Cow gentoo-dev 2022-10-03 13:27:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=063b3e0e3d31acd88f453831f71d74d976d66359

commit 063b3e0e3d31acd88f453831f71d74d976d66359
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-09-28 15:42:23 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-10-03 13:27:11 +0000

    www-client/firefox: enable wayland+pgo build on rapid
    
     - virtwl() function copied from
       https://cgit.alxu.ca/gentoo-overlay.git/tree/eclass/virtualwl.eclass
    
    Closes: https://bugs.gentoo.org/848858
    Closes: https://bugs.gentoo.org/767997
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/27512

 www-client/firefox/firefox-105.0.1.ebuild | 39 ++++++++++++++++++++++++++-----
 1 file changed, 33 insertions(+), 6 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2022-10-03 17:08:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5d952b94841d874c47714eb7e4e52d6594c137e

commit a5d952b94841d874c47714eb7e4e52d6594c137e
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-10-03 17:06:00 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-10-03 17:08:05 +0000

    Revert "www-client/firefox: enable wayland+pgo build on rapid"
    
    This reverts commit 063b3e0e3d31acd88f453831f71d74d976d66359.
    
     - forgot to include the part which disables virtualx.eclass's dependency on
       x11-base/xorg-server[xvfb].
    
    Bug: https://bugs.gentoo.org/848858
    Bug: https://bugs.gentoo.org/767997
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/firefox-105.0.1.ebuild | 39 +++++--------------------------
 1 file changed, 6 insertions(+), 33 deletions(-)
Comment 7 Larry the Git Cow gentoo-dev 2022-10-04 14:58:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15ac4bb53f345968163553213bf2f018a7249ab6

commit 15ac4bb53f345968163553213bf2f018a7249ab6
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-10-04 14:56:50 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-10-04 14:56:50 +0000

    www-client/firefox: add 105.0.2
    
     - enable wayland+pgo,
     - virtwl() function copied from
       https://cgit.alxu.ca/gentoo-overlay.git/tree/eclass/virtualwl.eclass
    
    Closes: https://bugs.gentoo.org/848858
    Closes: https://bugs.gentoo.org/767997
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest               |   98 +++
 www-client/firefox/firefox-105.0.2.ebuild | 1317 +++++++++++++++++++++++++++++
 2 files changed, 1415 insertions(+)