| Summary: | x11-misc/i3blocks-1.5 - Scripts in /usr/libexec/i3blocks/ aren't getting installed | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Rylan Dmello <mail> |
| Component: | Current packages | Assignee: | Ben Kohler <bkohler> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alarig, bkohler, kaikaikai, mail, mudler, sam |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
These were kicked out to an external i3blocks-contrib repo [1] before 1.5 release, it's mentioned in a new (unreleased) change to the readme [2]. I think we probably can/should start installing these by default on 1.5 but we will need some ebuild changes to download & compile/instlal the other contrib project. [1] https://github.com/vivien/i3blocks-contrib [2] https://github.com/vivien/i3blocks/commit/7d1cf4298d768d31d4614a149f3689e6173dbc00 There are other useful modules too, like volume-pulseaudio, https://github.com/vivien/i3blocks-contrib/tree/master/volume-pulseaudio Not sure how, but it would be very nice to have a mechanism to install other modules from i3blocks-contrib. Maybe make a use flag (on by default) which installs all these modules into /usr/libexec/i3blocks? After talking through it with a few others this morning, I think our best bet will be to add a new package for i3blocks-contrib, with i3blocks depending on it by default. I will work on this soon (tomorrow or later this week) but if you have something you want to submit already, let me know. (In reply to Ben Kohler from comment #3) > After talking through it with a few others this morning, I think our best > bet will be to add a new package for i3blocks-contrib, with i3blocks > depending on it by default. I will work on this soon (tomorrow or later > this week) but if you have something you want to submit already, let me know. Thanks for looking into this! I don't have anything specific to submit. On my end, I've just masked i3blocks-1.5 for now. This made my system revert to i3blocks-1.4-r1, on which my old i3blocks config is working as expected. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cbea404e02d5f5191ff4353d5810d43ee5903ffd commit cbea404e02d5f5191ff4353d5810d43ee5903ffd Author: Ben Kohler <bkohler@gentoo.org> AuthorDate: 2021-01-20 15:07:10 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2021-01-20 15:16:50 +0000 x11-misc/i3blocks-contrib: new package Bug: https://bugs.gentoo.org/766057 Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Ben Kohler <bkohler@gentoo.org> x11-misc/i3blocks-contrib/Manifest | 1 + .../i3blocks-contrib-1.4.0_p20201127.ebuild | 28 ++++++++++++++++++++++ x11-misc/i3blocks-contrib/metadata.xml | 11 +++++++++ 3 files changed, 40 insertions(+) Can you try i3blocks-1.5-r1 and see if it behaves as expected? I am testing. So far it works well. Many thanks!!! It works well here too, thanks! i3blocks-1.5-r1 is working for me too, thanks again! I did have to make one small change in my i3blocks config file after updating: I added an extra whitespace after every label so that it had the same spacing as before the update. But that's very minor. i3blocks-contrib looks pretty good. They seem to have added a few new widgets that are very interesting too. i will have to try all of them... I found one minor bug. I switched to bandwith3 and the font used for the up/down arrows isn’t pulled by the ebuild. On one of my computers I already had it but I didn’t find the one needed yet. Do you want me to open another bug for the PR? I can take care of both (the new bug and the PR) once I find the package to add. Let me know what you find, if it's dep-heavy then we might put it behind a USE flag Also, the temperature plugin depends on lm-sensors: https://github.com/vivien/i3blocks-contrib/tree/master/temperature Hmm looks like the list of optional runtime deps will be quite large, maybe we can print a list via einfo in pkg_post_install or the gentoo-readme eclass. I don't think we should hardwire dependencies on these. grep -A5 Dependencies */README.md afs/README.md:## Dependencies afs/README.md-- `fs` command suite shipped with the AFS client software afs/README.md-- python3 -- apt-upgrades/README.md:Dependencies: aptitude, bash apt-upgrades/README.md-Suggested: fonts-font-awesome -- arch-update/README.md:# Dependencies arch-update/README.md-* Arch Linux or another arch based distro arch-update/README.md-* python3 arch-update/README.md-* [pacman-contrib](https://www.archlinux.org/packages/?name=pacman-contrib) for `checkupdates` arch-update/README.md:# Optional Dependencies arch-update/README.md-* yaourt for aur updates arch-update/README.md-* fontawesome for awesome labels -- aur-update/README.md:## Dependencies aur-update/README.md- aur-update/README.md-- python3 [requests library](http://docs.python-requests.org/en/master/) aur-update/README.md-- optional: libnotify/notify-send aur-update/README.md- -- backlight/README.md:## Dependencies backlight/README.md-These tools from the xorg-suite are needed: backlight/README.md-- `xorg-xbacklight` backlight/README.md-- `xorg-xset` -- battery-poly/README.md:## Dependencies battery-poly/README.md-- python3 battery-poly/README.md-- sysfs (provided by Linux kernel since 2.5) -- battery/README.md:# Dependencies battery/README.md-* `acpi` -- battery2/README.md:# Dependencies battery2/README.md-fonts-font-awesome, acpi, python3 -- batterybar/README.md:# Dependencies batterybar/README.md-* acpi -- calendar/README.md:# Dependencies calendar/README.md-* yad calendar/README.md-* xdotool (for positioning of the popup) -- cpu_usage/README.md:# Dependencies cpu_usage/README.md-* `mpstat` -- disk-io/README.md:# Dependencies disk-io/README.md-iostat (sysstat package), fontawesome for the hard disk icon (fonts-font-awesome package) -- docker/README.md:# Dependencies docker/README.md-*docker* -- dunst/README.md:# Dependencies dunst/README.md-- [dunst](https://dunst-project.org/) dunst/README.md-- [Font Awesome](https://fontawesome.com) for the [bell](https://fontawesome.com/icons/bell?style=solid) and [bell-slash](https://fontawesome.com/icons/bell-slash?style=solid) icons -- email/README.md:# Dependencies email/README.md-Python 3, [python-keyring](https://pypi.python.org/pypi/keyring) (optional), email/README.md-gnome-keyring (if pyton-keyring using, also you able to use any other email/README.md-compatible backend) -- go/README.md:# Dependencies go/README.md-*go* and *awk* must be installed and accessible under your *$PATH*. go/README.md-It's highly likely to also install a Nerd Fonts patched font to get the Gopher icon. -- gpu-load/README.md:# Dependencies gpu-load/README.md-Choose one depends on your GPU. gpu-load/README.md-* `nvidia-settings` Note that on Debian-based systems, you have to add `contrib` and `non-free` to your `sources.list` in order to install the package via your package manager. gpu-load/README.md-* [`radeontop`](https://github.com/clbr/radeontop) -- kbdd_layout/README.md:Dependencies: kbdd (typically in package of the same name). -- key_light/README.md:# Dependencies key_light/README.md-* [upower](https://upower.freedesktop.org/) -- kubernetes/README.md:# Dependencies kubernetes/README.md-*kubectl* must be install and accessible under your *$PATH* -- monitor_manager/README.md:# Dependencies monitor_manager/README.md-python3, python3-tk, xrandr, fontawesome (fonts-font-awesome package), arandr suggested but not required. -- rofi-calendar/README.md:# Dependencies rofi-calendar/README.md-* rofi rofi-calendar/README.md-* cal from util-linux package, supporting --color=always -- ssid/README.md:Dependencies: `iw` -- sway-focusedwindow/README.md:Dependencies: swaymsg (typically distributed along with sway), [jq](https://github.com/stedolan/jq) -- tahoe-lafs/README.md:Dependencies: bash, curl, jq, tahoe-lafs (unless using a remote node) -- temperature/README.md:# Dependencies temperature/README.md-* `lm-sensors` -- time/README.md:# Dependencies time/README.md-perl -- usb/README.md:Dependencies: udev, python3, util-linux ( >= 2.23 ) usb/README.md-Suggested: fonts-font-awesome -- user/README.md:# Dependencies user/README.md-* `fontawesome. Not necessary but better install it` -- volume-pulseaudio/README.md:# Dependencies volume-pulseaudio/README.md-pulseaudio, alsa (alsa-utils package), fontawesome (fonts-font-awesome package) for the speaker symbols -- wlan-dbm/README.md:# Dependencies wlan-dbm/README.md-* `iw` -- ytdl-mpv/README.md:Dependencies: fonts-font-awesome, mpv, xclip, youtube-dl, perl, Data::Validate::URI perl module ytdl-mpv/README.md-(libdata-validate-uri-perl package) Hi everyone,
Great job with the new i3blocks + i3blocks-contrib ebuild :)
I understand adding a USE flag for each dependency would be a pain to handle. Maybe a handy middle ground could be 2 flags disabled by default like "minimal" & "extra", with some kind of "sane" default dependencies pulled:
RDEPEND="sys-apps/lm-sensors
sys-power/acpi"
What do you think?
Added some optfeature calls to suggest useful packages if they are not installed yet: https://gitweb.gentoo.org/repo/gentoo.git/commit/x11-misc/i3blocks-contrib?id=b7da5719890b5456a0e18121116b7af23de885c6 Feedback welcome. |
Hi, its looks like the ebuild for i3blocks-1.4-r1 used to install a number of scripts in /usr/libexec/i3blocks/: --- /usr/libexec/ >>> /usr/libexec/i3blocks/ >>> /usr/libexec/i3blocks/bandwidth >>> /usr/libexec/i3blocks/battery >>> /usr/libexec/i3blocks/cpu_usage >>> /usr/libexec/i3blocks/disk >>> /usr/libexec/i3blocks/iface >>> /usr/libexec/i3blocks/keyindicator >>> /usr/libexec/i3blocks/load_average >>> /usr/libexec/i3blocks/mediaplayer >>> /usr/libexec/i3blocks/memory >>> /usr/libexec/i3blocks/openvpn >>> /usr/libexec/i3blocks/temperature >>> /usr/libexec/i3blocks/volume >>> /usr/libexec/i3blocks/wifi These files don't seem to be getting installed anymore after I upgrade to the i3blocks-1.5 ebuild. Is this an install issue or something that's changed upstream; are these helper scripts not included anymore in i3blocks 1.5 and newer?