Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 766006

Summary: net-im/signal-desktop-bin-1.39.5: Outdated postinst message
Product: Gentoo Linux Reporter: haarp <main.haarp>
Component: Current packagesAssignee: Robert G. Siebeck <gentoo.2019>
Status: RESOLVED FIXED    
Severity: normal CC: jstein, proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/19515
https://github.com/gentoo/gentoo/pull/19634
Whiteboard:
Package list:
Runtime testing required: ---

Description haarp 2021-01-18 15:13:59 UTC
Signal's ebuild prints this message in postinst:

"xfce-extra/xfce4-statusnotifier-plugin for using the tray icon in Xfce desktop environments"

However, this package is deprecated upstream.

"As of xfce 4.15, the functionality provided by xfce4-statusnotifier-plugin has been integrated into the xfce4-panel's systray. Going forward, this plugin is considered to be deprecated."
- https://gitlab.xfce.org/panel-plugins/xfce4-statusnotifier-plugin

Furthermore, this message may lead users to fruitlessly try to get a tray icon working by installing this outdated package, when in reality they need a somewhat-hidden parameter `--start-in-tray` or `--use-tray-icon`.
- https://github.com/signalapp/Signal-Desktop/issues/2210#issuecomment-380383841

I suggest this postinst message instead:

"For using the tray icon on compatible desktop environments, start Signal with `--start-in-tray` or `--use-tray-icon`."


Thanks!
Comment 1 Larry the Git Cow gentoo-dev 2021-02-18 14:47:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa65424498656a9205f906abc0fa35cae02320b0

commit aa65424498656a9205f906abc0fa35cae02320b0
Author:     Robert Siebeck <gentoo.2019@r123.de>
AuthorDate: 2021-02-18 08:21:16 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-02-18 14:47:16 +0000

    net-im/signal-desktop-bin: add version 1.40.0
    
    Closes: https://bugs.gentoo.org/766006
    Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-im/signal-desktop-bin/Manifest                 |   1 +
 .../signal-desktop-bin-1.40.0.ebuild               | 114 +++++++++++++++++++++
 2 files changed, 115 insertions(+)
Comment 2 haarp 2021-02-18 18:08:05 UTC
thanks!
Comment 3 Joonas Niilola gentoo-dev 2021-02-19 06:35:43 UTC
FYI I had to revert the bump to 1.40.0 due to https://bugs.gentoo.org/771363 so the postinst message was also restorted to its previous state.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b8f7db4eb4455b4ff6965fcceb913a094e28af1a
Comment 4 Larry the Git Cow gentoo-dev 2021-02-25 06:23:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd35e5dcc13d7b1c785a1a4f8c195d8603a906f8

commit dd35e5dcc13d7b1c785a1a4f8c195d8603a906f8
Author:     Robert Siebeck <gentoo.2019@r123.de>
AuthorDate: 2021-02-24 19:01:09 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-02-25 06:23:29 +0000

    net-im/signal-desktop-bin: remove old versions.
    
    Closes: https://bugs.gentoo.org/766006
    Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>
    Closes: https://github.com/gentoo/gentoo/pull/19634
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-im/signal-desktop-bin/Manifest                 |   2 -
 .../signal-desktop-bin-1.39.6.ebuild               | 115 ---------------------
 .../signal-desktop-bin-1.40.0-r3.ebuild            | 115 ---------------------
 3 files changed, 232 deletions(-)