Bug 765583

Summary:	net-print/cups-2.3.3-r1: Install fails when built with sys-devel/slibtool
Product:	Gentoo Linux	Reporter:	orbea <orbea>
Component:	Current packages	Assignee:	Printing Team <printing>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ionen, sam
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/19069 https://bugs.gentoo.org/show_bug.cgi?id=780060
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	765709
Attachments:	build log emerge --info

Description orbea 2021-01-16 00:08:39 UTC

The install fails when building cups with slibtool.

  MAKEFLAGS='LIBTOOL=rlibtool' emerge -av net-print/cups

This because the backend/Makefile file has bogus libtool commands which GNU libtool silently consumes, but more strict implementations like slibtool will print an error instead.

  rlibtool: error: --mode must be specified.

This is easily resolved by removing libtool from the problematic commands as done in this upstream PR which has been ignored.

https://github.com/apple/cups/pull/5827

However cups has been forked by the previous maintainer which did merge this patch.

https://github.com/OpenPrinting/cups/pull/11

Comment 1 orbea 2021-01-16 00:10:19 UTC

Created attachment 683104 [details]
build log

Comment 2 orbea 2021-01-16 00:10:35 UTC

Created attachment 683107 [details]
emerge --info

Comment 3 Larry the Git Cow gentoo-dev

2021-01-16 11:53:18 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68545919747ad7b6ac2ca7681255f1371d0ed357

commit 68545919747ad7b6ac2ca7681255f1371d0ed357
Author:     Ørjan Malde <red@foxi.me>
AuthorDate: 2021-01-15 17:58:35 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-01-16 11:53:15 +0000

    net-print/cups: drop bogus libtool install invocations
    
    Closes: https://bugs.gentoo.org/765583
    Signed-off-by: Ørjan Malde <red@foxi.me>
    Closes: https://github.com/gentoo/gentoo/pull/19069
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 net-print/cups/cups-2.3.3-r1.ebuild              |  1 +
 net-print/cups/files/cups-2.3.3-no-libtool.patch | 25 ++++++++++++++++++++++++
 2 files changed, 26 insertions(+)

Comment 4 orbea 2021-03-11 16:14:55 UTC

The OpenPrinting repo where this fix has already been merged has taken over cups development for Linux/BSD/etc and the apple repo is now only for macOS as described in this comment.

https://github.com/apple/cups/pull/5827#issuecomment-796837736