Summary: | dev-libs/libcec-6.0.2: fix udev rule and set device to video group | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alan Swanson <reiver> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ionen |
Priority: | Normal | Keywords: | PATCH, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/20851 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
libcec-udev-rules-ebuild.patch
libcec-udev-rules-ebuild-take2.patch |
Created attachment 684040 [details]
libcec-udev-rules-ebuild-take2.patch
Obviously didn't test properly as not working on reboot.
Need to match plural SUBSYSTEMS=="usb" not SUBSYSTEM=="usb" for child tty device. Also (mis)understood that udev would stop at first lexical rule match but 45 was being overruled by 50 for group setting so leave as original 65.
Now properly tested with unplug/plug.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=496cb065e413016d6f788c26f485d55349b1c46b commit 496cb065e413016d6f788c26f485d55349b1c46b Author: Alan Swanson <reiver@improbability.net> AuthorDate: 2023-05-01 15:59:35 +0000 Commit: Viorel Munteanu <ceamac@gentoo.org> CommitDate: 2023-05-02 08:24:00 +0000 dev-libs/libcec: Fix udev rule Also change udev rule to set group ownership to "video" instead of "uucp". Closes: https://bugs.gentoo.org/765358 Closes: https://bugs.gentoo.org/896708 Signed-off-by: Alan Swanson <reiver@improbability.net> Closes: https://github.com/gentoo/gentoo/pull/20851 Signed-off-by: Viorel Munteanu <ceamac@gentoo.org> dev-libs/libcec/libcec-6.0.2-r1.ebuild | 131 +++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+) |
Created attachment 682777 [details] libcec-udev-rules-ebuild.patch The current (from upstream) libcec udev rule does not work due to two issues; 1) The rule needs to be suffixed with ".rules" not ".udev" to be considered by udev. I presume on Debian their toolset renames it on install. 2) The default 50-udev-default.rules would still take earlier precedence over a fixed 65-pulse-eight-usb-cec.rules by matching against the ttyACM0 device. Fix both by renaming the file. However, since 50-udev-default.rules no longer applies, we can also set the group to "video" instead of "uucp" since most users are likely to be running Kodi and will already be members of the video group. (Using sed to append the group rule only on lines rules with Pulse USB vendor ID 2548.) Same patch applies to libcec-4.0.7 (uncleanly due to whitespace change at "if use udev" line).