Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 764977

Summary: dev-qt/qtconcurrent-5.15.2 revdeps w/ gcc-11: qtconcurrentthreadengine.h:250:50: error: invalid declarator before ‘*’ token
Product: Gentoo Linux Reporter: andy <hedmoo>
Component: Current packagesAssignee: Qt Bug Alias <qt>
Status: RESOLVED FIXED    
Severity: normal CC: sam, vowstar
Priority: Normal Keywords: PullRequest, UPSTREAM
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://bugreports.qt.io/browse/QTBUG-90568
See Also: https://github.com/gentoo/gentoo/pull/22039
Whiteboard: fixed in kde-qt-5.15.2-c9543da6
Package list:
Runtime testing required: ---
Bug Depends on: 806797    
Bug Blocks: 732706    
Attachments: emerge --info dev-qt/qtconcurrent
build.log

Description andy 2021-01-11 16:48:16 UTC
my own package fails to build against dev-qt/qtconcurrent with :

In file included from /usr/include/qt5/QtConcurrent/qtconcurrentiteratekernel.h:49,
                 from /usr/include/qt5/QtConcurrent/qtconcurrentfilterkernel.h:47,
                 from /usr/include/qt5/QtConcurrent/qtconcurrentfilter.h:47,
                 from /usr/include/qt5/QtConcurrent/QtConcurrent:8,
                 from ../rpcs3-9d74d42f2a8f7509a4a9000ea472475f71c059fa/rpcs3/rpcs3qt/save_manager_dialog.cpp:12:
/usr/include/qt5/QtConcurrent/qtconcurrentthreadengine.h:250:50: error: invalid declarator before ‘*’ token
  250 |     ThreadEngineStarter<void>(ThreadEngine<void> *_threadEngine)
      |                                                  ^
/usr/include/qt5/QtConcurrent/qtconcurrentthreadengine.h:250:49: error: expected ‘)’ before ‘*’ token
  250 |     ThreadEngineStarter<void>(ThreadEngine<void> *_threadEngine)
      |                              ~                  ^~
      |                                                 )
Comment 1 andy 2021-01-11 16:53:12 UTC
Created attachment 682447 [details]
emerge --info dev-qt/qtconcurrent
Comment 2 andy 2021-01-11 16:58:01 UTC
Created attachment 682450 [details]
build.log

build.log of my package
Comment 3 andy 2021-01-11 17:01:25 UTC
i have update dev-qt/* with : https://github.com/gentoo/gentoo/pull/19025
Comment 4 Andreas Sturmlechner gentoo-dev 2021-01-11 17:03:45 UTC
It is unnecessary to open more bugs about qtbase module packages. This is already covered by the pending PR.

*** This bug has been marked as a duplicate of bug 752012 ***
Comment 5 andy 2021-01-11 17:11:26 UTC
(In reply to Andreas Sturmlechner from comment #4)
> It is unnecessary to open more bugs about qtbase module packages. This is
> already covered by the pending PR.
> 
> *** This bug has been marked as a duplicate of bug 752012 ***

how is this covered? if you are talking about your pull request.. it did not help
because as i said i have already pulled it down to me from your git.that is why i am opening a new bug.
Comment 6 Andreas Sturmlechner gentoo-dev 2021-01-11 17:37:01 UTC
You've attached the wrong build.log, so we can't check if you had actually applied the patch.
Comment 7 Andreas Sturmlechner gentoo-dev 2021-01-11 17:39:36 UTC
I see, it is your own package. Please be more precise when you file bugs. $summary does not match $content right now.
Comment 8 Andreas Sturmlechner gentoo-dev 2021-01-11 17:42:48 UTC
This is highly unsupported territory now.

- GCC-11 is not nearly ready in Portage (with a release)
- dev-qt/qtconcurrent may or may not have been built with a patch not yet in tree
- Reported package is not even in Portage


Please try to reproduce it with another revdep of qtconcurrent that is actually in tree.
Comment 9 andy 2021-01-11 18:23:28 UTC
(In reply to Andreas Sturmlechner from comment #8)
> This is highly unsupported territory now.

yes it is.

> - GCC-11 is not nearly ready in Portage (with a release)

i know but in make.conf. i need this:

#For Gcc Live
I_PROMISE_TO_SUPPLY_PATCHES_WITH_BUGS=1


> - dev-qt/qtconcurrent may or may not have been built with a patch not yet in
> tree
> - Reported package is not even in Portage

sorry if i was a bit ahead when i copied your gentoo fork to test your commits and made a bug with that. i thought the changes was going to be merged quite fast to the portage tree.

> Please try to reproduce it with another revdep of qtconcurrent that is
> actually in tree.

i will wait for your PR/changes/commits to make it the to portage tree and post back because dev-qt/qtconcurrent-5.15.2::gentoo ATM fails with the same..
Comment 10 Andreas Sturmlechner gentoo-dev 2021-01-24 11:04:42 UTC
[shot in the dark] Maybe patching qtconcurrent with this commit can get you further? https://github.com/qt/qtbase/commit/a4071c18de94e41a157642cd0dfa0f4748d531af

Otherwise, it really makes sense to contact upstream about your build failure, and maybe link back here.

Last commit to qtconcurrentthreadengine.h in 5.15 branch happened in 2018, and beyond my above link, dev branch (qt6) is already starting to diverge quite a bit.
Comment 11 andy 2021-01-24 13:40:04 UTC
(In reply to Andreas Sturmlechner from comment #10)
> [shot in the dark] Maybe patching qtconcurrent with this commit can get you
> further?
> https://github.com/qt/qtbase/commit/a4071c18de94e41a157642cd0dfa0f4748d531af
> 
> Otherwise, it really makes sense to contact upstream about your build
> failure, and maybe link back here.
> 
> Last commit to qtconcurrentthreadengine.h in 5.15 branch happened in 2018,
> and beyond my above link, dev branch (qt6) is already starting to diverge
> quite a bit.

thank you Andreas. will test right after i have updated dev-qt*::gentoo with the merged PR  gentoo/gentoo#19025 :)
Comment 12 andy 2021-01-24 14:31:47 UTC
Andreas . your [shot in the dark] did not work so i have made a bug report: https://bugreports.qt.io/browse/QTBUG-90568
Comment 13 Andreas Sturmlechner gentoo-dev 2021-03-22 00:02:23 UTC
Looks like upstream have a fix for you.
Comment 14 andy 2021-03-22 05:25:23 UTC
(In reply to Andreas Sturmlechner from comment #13)
> Looks like upstream have a fix for you.

Yes it has. dev-qt/* with gcc-11 works for me.
Comment 15 Andreas Sturmlechner gentoo-dev 2021-04-08 15:43:06 UTC
If the backport works for 5.15 as well then we could try and promote it for inclusion in the KDE Qt5 patch collection.

https://dot.kde.org/2021/04/06/announcing-kdes-qt-5-patch-collection
Comment 16 andy 2021-04-09 06:04:14 UTC
(In reply to Andreas Sturmlechner from comment #15)
> If the backport works for 5.15 as well then we could try and promote it for
> inclusion in the KDE Qt5 patch collection.
> 
> https://dot.kde.org/2021/04/06/announcing-kdes-qt-5-patch-collection

sounds good . but in the qt report they told me that this could be a gcc bug.
maybe hold it till we have the first release of gcc-11.
Comment 18 Andreas Sturmlechner gentoo-dev 2021-05-22 22:34:36 UTC
*** Bug 788979 has been marked as a duplicate of this bug. ***
Comment 19 Larry the Git Cow gentoo-dev 2021-08-23 02:06:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e9d13c50ef08300d32a2f463cb69ece1fdaae838

commit e9d13c50ef08300d32a2f463cb69ece1fdaae838
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-08-23 02:00:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-08-23 02:01:04 +0000

    dev-qt/qtconcurrent: revbump for GCC 11 fix, with additional patch
    
    Closes: https://bugs.gentoo.org/764977
    Closes: https://bugs.gentoo.org/806797
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/qtconcurrent-5.15.2-gcc11.patch          | 45 ++++++++++++++++++++++
 dev-qt/qtconcurrent/qtconcurrent-5.15.2-r1.ebuild  | 30 +++++++++++++++
 2 files changed, 75 insertions(+)
Comment 20 Larry the Git Cow gentoo-dev 2021-08-25 14:36:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=130779e3d0fe86f7084def055cbe4be752eaf43d

commit 130779e3d0fe86f7084def055cbe4be752eaf43d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-15 22:26:43 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-25 14:35:47 +0000

    dev-qt/qtconcurrent: 5.15.2-r10 version bump at KDE c2ea67ec
    
    EAPI-8
    
    Closes: https://bugs.gentoo.org/764977
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtconcurrent/Manifest                       |  1 +
 dev-qt/qtconcurrent/qtconcurrent-5.15.2-r10.ebuild | 25 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)