Bug 764791 – app-emulation/containerd-1.4.3-r1: incorrect git commit for version

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Shaumyadeep Chaudhuri 2021-01-10 11:37:30 UTC]

The commit used in the ebuild for CONTAINERD_COMMIT is incorrect.

Currently it uses `ea765ab`, the upstream commit for 1.4.3 is `269548f`.

The current commit leads to an error when trying to use docker, with docker giving error 

ttrpc: closed: unknown

[Comment 1 Argh!... Rats!... 2021-01-13 12:15:10 UTC]

I hereby confirm:
- commit used is incorrect. Current commit is 269548f. Commit used in ebuild "containerd-1.4.3-r1.ebuild" is ea765ab which is for version 1.3.9
- Error at start of any docker container

Reproducable by : "docker run -it hello-world"

Errormessage:
docker: Error response from daemon: ttrpc: closed: unknown.
ERRO[0000] error waiting for container: context canceled


However....

i did the following:
-- created a local ebuild and changed the commit-number to 269548f.
-- emerged the adapted containerd ebuild

Result:
- I still get the same error when starting a container...

@Shaumyadeep Chaudhuri
-  Thanks for reporting. Congrats for beeing first. Happy new Year!

[Comment 2 Sam James 2021-01-13 15:06:15 UTC]

(In reply to Argh!... Rats!... from comment #1)
> However....
> 
> i did the following:
> -- created a local ebuild and changed the commit-number to 269548f.
> -- emerged the adapted containerd ebuild
>

I suspect this is because if you don't update the -> ... part in SRC_URI, portage won't redownload the file?

[Comment 3 Larry the Git Cow 2021-01-13 15:12:00 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4543f0e69a92d8696950524ec2e64bd5d5a0234b

commit 4543f0e69a92d8696950524ec2e64bd5d5a0234b
Author:     Sam James <[e-mail]>
AuthorDate: 2021-01-13 15:11:54 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-01-13 15:11:54 +0000

    app-emulation/containerd: fix 1.4.3 tarball
    
    The commit wasn't updated.
    
    Closes: https://bugs.gentoo.org/764791
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sam James <[e-mail]>

 app-emulation/containerd/Manifest                              |  2 +-
 .../{containerd-1.4.3-r1.ebuild => containerd-1.4.3-r2.ebuild} | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)

[Comment 4 Argh!... Rats!... 2021-01-14 23:55:16 UTC]

(In reply to Sam James from comment #2)
> (In reply to Argh!... Rats!... from comment #1)
> > However....
> > 
> > i did the following:
> > -- created a local ebuild and changed the commit-number to 269548f.
> > -- emerged the adapted containerd ebuild
> >
> 
> I suspect this is because if you don't update the -> ... part in SRC_URI,
> portage won't redownload the file?

Here a diff between my adaption and the current 1.4.3-r2 just released:
 diff /usr/local/portage/app-emulation/containerd/containerd-1.4.3-r1.ebuild  /usr/portage/app-emulation/containerd/containerd-1.4.3-r2.ebuild
1c1
< # Copyright 1999-2020 Gentoo Authors
---
> # Copyright 1999-2021 Gentoo Authors
8c8
< CONTAINERD_COMMIT="269548f"
---
> CONTAINERD_COMMIT="269548fa27e0089a8b8278fc4fc781d7f65a939b"
15c15,16
< SRC_URI="https://github.com/containerd/${PN}/archive/${CONTAINERD_COMMIT}.tar.gz -> ${P}.tar.gz"
---
> # NOTE: Drop '.gh' on bump, it's there because of bug #764791
> SRC_URI="https://github.com/containerd/${PN}/archive/${CONTAINERD_COMMIT}.tar.gz -> ${P}.gh.tar.gz"
81c82,83
<       rm -rf docs/man || die
---
>       rm -r docs/man || die




Anyway...thanks for fixing! Works on my side!