Summary: | app-emulation/docker-20.10.1 silently removes /usr/bin/docker | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
Component: | Current packages | Assignee: | William Hubbs <williamh> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | gentoo, gyakovlev, holger, qa, wgh |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=764443 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Michał Górny
2021-01-06 15:56:47 UTC
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=44ffef0c0276f88ba844b1437c310599782a0fcd commit 44ffef0c0276f88ba844b1437c310599782a0fcd Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2021-01-06 15:59:50 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2021-01-06 16:00:12 +0000 profiles.mask: Mask new app-emulation/docker* Bug: https://bugs.gentoo.org/764122 Signed-off-by: Michał Górny <mgorny@gentoo.org> profiles/package.mask | 9 +++++++++ 1 file changed, 9 insertions(+) I am sorry, I have apparently missed a tiny ewarn that runs conditionally when you install it for the first time. Of course, that isn't very helpful if you use any kind of automation and you are informed *after the fact*. Now, what you *could* have done is: 1. Added IUSE=+cli for the time being that prevents immediate breakage, while allowing people who don't need CLI to disable it. You could also issue the warning with USE=cli, asking people to put docker-cli in @world. 2. Published a news item because this is a major breaking change. 3. Warned in *pkg_pretend* so that people can act *before* their system is broken. The mask is pretty annoying, mainly because I waited for 20 days to get the new version. I do notice the warning so I emerged the docker-cli package. But this mask breaks my daily @world upgrade. I have to emerge the package I want to upgrade manually if I don't want to downgrade docker and related packages. Anyway, there are some more change you can make besides the +cli USE: 1. bump version to 20.10.2 2. add a daemon or dockerd IUSE for docker-cli, in case someone masks it because they only want to build the cli 3. add a news item, and hope people who don't care postinst warning will check the news Again, I am very unhappy with this emotional and unprofessional profile-level mask for a tiny mistake which can be expected on testing version. I told WilliamH about this yesterday, as I had also missed the ewarn and suggested to add one. Pretty harsh to singlehandedly decide to mask the new version though. I didn't see the same thing happen when openssh got upgraded (bug 709748) and I consider that to be at least equally bad when using "any kind of automation". The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=10ee4c2641fc908fd6e28e7577d9b89c775cf279 commit 10ee4c2641fc908fd6e28e7577d9b89c775cf279 Author: William Hubbs <williamh@gentoo.org> AuthorDate: 2021-01-08 17:49:58 +0000 Commit: William Hubbs <williamh@gentoo.org> CommitDate: 2021-01-08 17:53:24 +0000 app-emulation/docker: 20.10.2 bump Bug: https://bugs.gentoo.org/764122 Signed-off-by: William Hubbs <williamh@gentoo.org> app-emulation/docker/Manifest | 1 + app-emulation/docker/docker-20.10.2.ebuild | 294 +++++++++++++++++++++++++++++ app-emulation/docker/metadata.xml | 6 + 3 files changed, 301 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=325606bb0e378299a622a2a1f2f394e628cc7fba commit 325606bb0e378299a622a2a1f2f394e628cc7fba Author: William Hubbs <williamh@gentoo.org> AuthorDate: 2021-01-08 19:39:39 +0000 Commit: William Hubbs <williamh@gentoo.org> CommitDate: 2021-01-08 19:41:16 +0000 profiles/package.mask: unmask docker 20.10.2 Closes: https://bugs.gentoo.org/764122 Signed-off-by: William Hubbs <williamh@gentoo.org> profiles/package.mask | 9 --------- 1 file changed, 9 deletions(-) |