Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 764035

Summary: dev-libs/liborcus-0.15.4 fails to build with gcc11
Product: Gentoo Linux Reporter: Geoff Leach <gl>
Component: Current packagesAssignee: Gentoo Office Team <office>
Status: RESOLVED FIXED    
Severity: normal CC: ionen
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 732706    
Attachments: patch to #include <limits> in several files
upstream patch
build.log and emerge --info.txt

Description Geoff Leach 2021-01-06 06:45:09 UTC
Created attachment 681391 [details, diff]
patch to #include <limits> in several files

Found liborcus failed to build with gcc11

Errors due to not #include <limits>, as reported in multiple packages now, some in the gcc11 tracker

e.g. for liborcus-0.15.4

orcus_xlsx.cpp:313:35: error: ‘numeric_limits’ was not declared in this scope
  313 |     return it == rank_map.end() ? numeric_limits<size_t>::max() : it->second;

Only dependent in my tree is libreoffice.

BTW I found same with liborcus-0.16.1 and liborcus-9999 (gave them a try even though libreoffice requires dev-libs/liborcus:0/0.15)

Patch attached.
Comment 1 andy 2021-01-06 09:32:43 UTC
fixed upstream .
Comment 2 andy 2021-01-06 09:33:49 UTC
Created attachment 681463 [details, diff]
upstream patch
Comment 3 Ionen Wolkens gentoo-dev 2021-01-07 16:45:55 UTC
Created attachment 681811 [details]
build.log and emerge --info.txt

Can reproduce with gcc-11.0.9999-d54be5a, attaching full log+info for completeness.

But what do you mean by fixed upstream? Link? Still getting error liborcus @34865af, it would certainly be good to get it fixed there instead.
Comment 4 andy 2021-01-08 06:23:44 UTC
(In reply to Ionen Wolkens from comment #3)
> Created attachment 681811 [details]
> build.log and emerge --info.txt
> 
> Can reproduce with gcc-11.0.9999-d54be5a, attaching full log+info for
> completeness.
> 
> But what do you mean by fixed upstream? Link? Still getting error liborcus
> @34865af, it would certainly be good to get it fixed there instead.

i did not know that it was ok to add links here but here you go:

hedmo@mya51 ~ $ cat fails_gcc11-20210104 | grep dev-libs/liborcus-0.16.1
dev-libs/liborcus-0.16.1 ## fixed upstream https://gerrit.libreoffice.org/c/core/+/104074/2/external/liborcus/include.patch.0#1
hedmo@mya51 ~ $

as this is from libreoffice i will double check with liborcus at gitlab 
and make a merge request if he does not have it..
Comment 5 andy 2021-01-08 07:44:57 UTC
made a merge request upstream : https://gitlab.com/orcus/orcus/-/merge_requests/97
Comment 6 andy 2021-01-09 06:20:03 UTC
fixed upsream.
Comment 7 Larry the Git Cow gentoo-dev 2021-01-24 13:02:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3d1c1e19ca22ad4ed81932940665e205afe08a97

commit 3d1c1e19ca22ad4ed81932940665e205afe08a97
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-01-24 12:46:13 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-01-24 12:59:06 +0000

    dev-libs/liborcus: Fix build with GCC-11, python3_9
    
    Upstream commits:
    50506d534230d90de2b0a2af3fb072428c942a4e
    3bfa1a000e4639fe68781c584356ceea7c6b1a72
    5e8fb255dc6bc9b7084a05b8dc24f31417542e5e
    
    Reported-by: Geoff Leach <gl@cs.rmit.edu.au>
    Thanks-to: andy <hedmoo@yahoo.com>
    Closes: https://bugs.gentoo.org/764035
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../liborcus/files/liborcus-0.15.4-gcc11.patch     | 72 ++++++++++++++++++++++
 dev-libs/liborcus/liborcus-0.15.4.ebuild           |  9 ++-
 2 files changed, 78 insertions(+), 3 deletions(-)