Bug 763999 – dev-libs/libtomcrypt should BDEPEND on sys-devel/libtool

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description matoro 2021-01-05 23:45:20 UTC]

* Package:    dev-libs/libtomcrypt-1.18.2-r1
 * Repository: gentoo
 * Maintainer: [e-mail] [e-mail]
 * USE:        abi_x86_64 amd64 elibc_glibc gmp kernel_linux libtommath userland_GNU
 * FEATURES:   compressdebug network-sandbox preserve-libs sandbox splitdebug userpriv usersandbox
 * FEATURES='assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg compress-build-logs compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr'
 * CFLAGS='-march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe -Wl,-O1 -Wl,--as-needed'
 * CXXFLAGS='-march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe -Wl,-O1 -Wl,--as-needed'
 * FFLAGS='-march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe -Wl,-O1 -Wl,--as-needed'
 * FCFLAGS='-march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe -Wl,-O1 -Wl,--as-needed'
 * F77FLAGS='-march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe -Wl,-O1 -Wl,--as-needed'
 * LDFLAGS='-Wl,-O1 -Wl,--as-needed -march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe'
 * MAKEOPTS='-j32'
 * gcc (Gentoo 10.2.0-r5 p6) 10.2.0
 * g++ (Gentoo 10.2.0-r5 p6) 10.2.0
 * GNU ld (Gentoo 2.35.1 p2) 2.35.1
 * Linux matoro-desktop 5.10.4 #1 SMP Wed Dec 30 16:03:39 MST 2020 x86_64 AMD Ryzen 9 3950X 16-Core Processor AuthenticAMD GNU/Linux
>>> Unpacking source...
>>> Unpacking libtomcrypt-1.18.2.tar.xz to /var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/work
>>> Source unpacked in /var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/work
>>> Preparing source in /var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/work/libtomcrypt-1.18.2 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/work/libtomcrypt-1.18.2 ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/work/libtomcrypt-1.18.2 ...
make -j32 'CFLAGS=-march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe -Wl,-O1 -Wl,--as-needed -DGMP_DESC=1 -DLTM_DESC=1 -DUSE_GMP=1' CC=x86_64-pc-linux-gnu-gcc AR=x86_64-pc-linux-gnu-ar RANLIB=x86_64-pc-linux-gnu-ranlib LIBPATH=/usr/lib64 INCPATH=/usr/include IGNORE_SPEED=1 -f makefile.shared library 
libtool --mode=compile --tag=CC x86_64-pc-linux-gnu-gcc -I./src/headers/ -Wall -Wsign-compare -Wshadow -DLTC_SOURCE -Wextra -Wsystem-headers -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wwrite-strings -Wno-type-limits -DGIT_VERSION=\"1.18.2\" -march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe -Wl,-O1 -Wl,--as-needed -DGMP_DESC=1 -DLTM_DESC=1 -DUSE_GMP=1   -Wl,-O1 -Wl,--as-needed -march=native -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=32 -fuse-linker-plugin -pipe -o src/ciphers/aes/aes.o -c src/ciphers/aes/aes.c
make: libtool: No such file or directory
make: *** [makefile.shared:47: src/ciphers/aes/aes.o] Error 127
 * ERROR: dev-libs/libtomcrypt-1.18.2-r1::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=dev-libs/libtomcrypt-1.18.2-r1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=dev-libs/libtomcrypt-1.18.2-r1::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/temp/build.log.gz'.
 * The ebuild environment file is located at '/var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/temp/environment'.
 * Working directory: '/var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/work/libtomcrypt-1.18.2'
 * S: '/var/tmp/portage/dev-libs/libtomcrypt-1.18.2-r1/work/libtomcrypt-1.18.2'

Reproducible: Always

[Comment 1 matoro 2021-01-05 23:47:03 UTC]

Created attachment 681367 [details]
emerge --info

[Comment 2 Larry the Git Cow 2021-01-06 00:02:27 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71bdf96717e70de168c9390452f375244807ff4d

commit 71bdf96717e70de168c9390452f375244807ff4d
Author:     Sam James <[e-mail]>
AuthorDate: 2021-01-06 00:00:16 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-01-06 00:00:16 +0000

    dev-libs/libtomcrypt: add libtool BDEPEND
    
    Closes: https://bugs.gentoo.org/763999
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sam James <[e-mail]>

 dev-libs/libtomcrypt/libtomcrypt-1.18.2-r1.ebuild | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8c6dbafdc9c5fc5d1f6b3c972f1d3c39eb8d34e1

commit 8c6dbafdc9c5fc5d1f6b3c972f1d3c39eb8d34e1
Author:     Sam James <[e-mail]>
AuthorDate: 2021-01-06 00:01:59 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-01-06 00:01:59 +0000

    dev-libs/tomsfastmath: add libtool BDEPEND
    
    Bug: https://bugs.gentoo.org/763999
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sam James <[e-mail]>

 dev-libs/tomsfastmath/tomsfastmath-0.13.1-r1.ebuild | 7 ++++---
 dev-libs/tomsfastmath/tomsfastmath-0.13.1.ebuild    | 7 ++++---
 2 files changed, 8 insertions(+), 6 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b184cbefd246dcc53bfcbd955649c3e495835bc

commit 5b184cbefd246dcc53bfcbd955649c3e495835bc
Author:     Sam James <[e-mail]>
AuthorDate: 2021-01-06 00:00:56 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-01-06 00:00:56 +0000

    dev-libs/libtommath: add libtool BDEPEND
    
    Bug: https://bugs.gentoo.org/763999
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sam James <[e-mail]>

 dev-libs/libtommath/libtommath-1.2.0.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

[Comment 3 Sam James 2021-01-06 00:02:46 UTC]

Thanks!

[Comment 4 matoro 2021-01-11 01:32:55 UTC]

(In reply to Sam James from comment #3)
> Thanks!

I know this should technically be a separate bug, but since you were able to take care of this one so fast, could you also move the two lib dependencies (dev-libs/libtommath & dev-libs/tomsfastmath) to RDEPEND instead of DEPEND?  They are runtime deps and dev-libs/libtomcrypt links against them.

[Comment 5 Sam James 2021-01-11 07:58:50 UTC]

(In reply to matoro from comment #4)
> (In reply to Sam James from comment #3)
> > Thanks!
> 
> I know this should technically be a separate bug, but since you were able to
> take care of this one so fast, could you also move the two lib dependencies
> (dev-libs/libtommath & dev-libs/tomsfastmath) to RDEPEND instead of DEPEND? 
> They are runtime deps and dev-libs/libtomcrypt links against them.

Wow, how embarrassing. That's an oversight. Thank you!

[Comment 6 matoro 2021-01-11 14:20:56 UTC]

(In reply to Sam James from comment #5)
> (In reply to matoro from comment #4)
> > (In reply to Sam James from comment #3)
> > > Thanks!
> > 
> > I know this should technically be a separate bug, but since you were able to
> > take care of this one so fast, could you also move the two lib dependencies
> > (dev-libs/libtommath & dev-libs/tomsfastmath) to RDEPEND instead of DEPEND? 
> > They are runtime deps and dev-libs/libtomcrypt links against them.
> 
> Wow, how embarrassing. That's an oversight. Thank you!

No thank *you*!  I wish most maintainers were this responsive!