| Summary: | app-crypt/aescrypt-3.14 does not respect LDFLAGS | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | esigra, fedeliallalinea |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/21633 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 331933 | ||
| Attachments: |
build.log
aescrypt-3.14-ldflags.patch |
||
|
Description
Agostino Sarubbo
2021-01-05 09:38:23 UTC
Created attachment 681235 [details]
build.log
build log and emerge --info
Tell me if I should file a separate bug for this (I found this bug while searching for aescrypt), but aescrypt also does not respect the static USE flag. These are the packages that would be merged, in order: Calculating dependencies... done! [ebuild R ~] app-crypt/aescrypt-3.14::gentoo USE="static -X" 0 KiB Total: 1 package (1 reinstall), Size of downloads: 0 KiB >>> Verifying ebuild manifests >>> Emerging (1 of 1) app-crypt/aescrypt-3.14::gentoo * aescrypt-3.14.tgz BLAKE2B SHA512 size ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking aescrypt-3.14.tgz to /var/tmp/portage/app-crypt/aescrypt-3.14/work >>> Source unpacked in /var/tmp/portage/app-crypt/aescrypt-3.14/work >>> Preparing source in /var/tmp/portage/app-crypt/aescrypt-3.14/work/aescrypt-3.14 ... * Applying aescrypt-3.14-iconv.patch ... [ ok ] >>> Source prepared. >>> Configuring source in /var/tmp/portage/app-crypt/aescrypt-3.14/work/aescrypt-3.14 ... >>> Source configured. >>> Compiling source in /var/tmp/portage/app-crypt/aescrypt-3.14/work/aescrypt-3.14 ... make -j4 --load-average=4 'CFLAGS=-O2 -pipe -fomit-frame-pointer -march=ivybridge -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -maes -mpclmul -mpopcnt -mavx -msse4.2 -msse4.1 -mrdrnd -mf16c -mfsgsbase -mfxsr -mxsave -mxsaveopt --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=6144 -mtune=ivybridge -fstack-protector-strong -mfpmath=sse -DDISABLE_ICONV -Wall -Wextra -pedantic -std=c99 -D_FILE_OFFSET_BITS=64' 'LDFLAGS=-Wl,-O1 -Wl,--as-needed -static' CC=x86_64-pc-linux-gnu-gcc [...] $ ls -al /usr/bin/aescrypt -rwxr-xr-x 1 root root 59584 2021-07-05 10:31:35 /usr/bin/aescrypt* $ ldd /usr/bin/aescrypt linux-vdso.so.1 (0x00007fff155df000) libc.so.6 => /lib64/libc.so.6 (0x00007fec22f33000) /lib64/ld-linux-x86-64.so.2 (0x00007fec230d4000) Created attachment 723802 [details, diff]
aescrypt-3.14-ldflags.patch
Patch to solve problem
Hello, thanks for the patch. I believe you can speed up the process by making a pull-request via Github. (In reply to Agostino Sarubbo from comment #4) > Hello, thanks for the patch. I believe you can speed up the process by > making a pull-request via Github. In this case, it's better create a new revision ebuild or not? (In reply to Marco Genasci from comment #5) > In this case, it's better create a new revision ebuild or not? Yes, a new revision is the right way (In reply to Agostino Sarubbo from comment #6) > (In reply to Marco Genasci from comment #5) > > In this case, it's better create a new revision ebuild or not? > > Yes, a new revision is the right way Conceptually, yes, but with common sense added I disagree. Most people don't set custom LDFLAGS so the program works with its defaults, and this would cause a rebuild for everyone potentially breaking each update. Now there doesn't seem to be a strict policy either way. I'd say don't revbump here. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4cd20ef753adcbf7fae65db20d028c90b7e459bc commit 4cd20ef753adcbf7fae65db20d028c90b7e459bc Author: Marco Genasci <fedeliallalinea@gmail.com> AuthorDate: 2021-07-14 09:05:03 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-07-16 11:46:13 +0000 app-crypt/aescrypt: fix LDFLAGS in Makefile Closes: https://bugs.gentoo.org/763660 Package-Manager: Portage-3.0.20, Repoman-3.0.2 Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/21633 Signed-off-by: Joonas Niilola <juippis@gentoo.org> app-crypt/aescrypt/aescrypt-3.14.ebuild | 5 ++++- app-crypt/aescrypt/files/aescrypt-3.14-ldflags.patch | 20 ++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) |