Bug 763177

Summary:	dev-cpp/nlohmann_json-3.9.1: should not build tests without use test
Product:	Gentoo Linux	Reporter:	tusooa <tusooa>
Component:	Current packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description tusooa 2021-01-02 20:09:46 UTC

nlohmann_json will build tests by default if it is built as a standalone project. (https://github.com/nlohmann/json/blob/develop/CMakeLists.txt). We should -DJSON_BuildTests=OFF if we are not doing tests.

Reproducible: Always

Steps to Reproduce:
1. FEATURES=-test emerge dev-cpp/nlohmann_json
Actual Results:  
Tests are built.

Expected Results:  
Tests are not built.

Comment 1 Sam James archtester

2021-01-02 20:14:27 UTC

I thought I’d done this, thanks!

Comment 2 Larry the Git Cow gentoo-dev

2021-01-02 21:08:56 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b303773638d9da63596101266686762a5c6712d4

commit b303773638d9da63596101266686762a5c6712d4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-01-02 21:08:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-02 21:08:53 +0000

    dev-cpp/nlohmann_json: (really) build tests conditionally
    
    Closes: https://bugs.gentoo.org/763177
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-cpp/nlohmann_json/nlohmann_json-3.9.1.ebuild | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)