Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 761772

Summary: net-mail/mailbase-1.5-r1: please review Prefix changes
Product: Gentoo Linux Reporter: Fabian Groffen <grobian>
Component: Current packagesAssignee: Eray Aslan <eras>
Status: RESOLVED FIXED    
Severity: normal CC: prefix, sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---

Description Fabian Groffen gentoo-dev 2020-12-26 12:27:27 UTC
We need to ensure mailcap points to binaries inside the Prefix, for that we just copy the file to modify it.

Please let me know if you're ok with merging this, thanks!

+++ mailbase-1.5-r1.ebuild      2020-12-26 13:20:16.404922493 +0000
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
-inherit pam
+inherit pam prefix
 
 DESCRIPTION="MTA layout package"
 SRC_URI=""
@@ -26,8 +26,10 @@
        dodir /etc/mail
        insinto /etc/mail
        doins "${FILESDIR}"/aliases
+       cp "${FILESDIR}"/mailcap .
+       hprefixify mailcap
        insinto /etc
-       doins "${FILESDIR}"/mailcap
+       doins mailcap
        doman "${FILESDIR}"/mailcap.5
 
        dosym spool/mail /var/mail
Comment 1 Eray Aslan gentoo-dev 2020-12-28 13:22:41 UTC
ugh (for hprefixify)

how about we get rid of absolute paths in mailcap file?  would that solve your problem?
Comment 2 Fabian Groffen gentoo-dev 2020-12-28 13:29:21 UTC
yes, and I would prefer that too, because this file just defines tools to use, and if they exist in the host system, then YOLO is fine, sort of.
Comment 3 Larry the Git Cow gentoo-dev 2020-12-29 10:41:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2b712ce31a89f4873ae76c1f5a4148eebfc7533

commit f2b712ce31a89f4873ae76c1f5a4148eebfc7533
Author:     Eray Aslan <eras@gentoo.org>
AuthorDate: 2020-12-29 10:41:04 +0000
Commit:     Eray Aslan <eras@gentoo.org>
CommitDate: 2020-12-29 10:41:30 +0000

    net-mail/mailbase: do not hardcode application paths
    
    as it obviously wont work for gentoo prefix project.
    and review and revize the mailcap file while at it.
    
    Bug: https://bugs.gentoo.org/761772
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Eray Aslan <eras@gentoo.org>

 net-mail/mailbase/files/mailcap-r1    | 19 +++++++++++++++
 net-mail/mailbase/mailbase-1.6.ebuild | 46 +++++++++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)
Comment 4 Eray Aslan gentoo-dev 2020-12-29 10:42:20 UTC
please let me know if mailbase-1.6 works for prefix.  thank you
Comment 5 Larry the Git Cow gentoo-dev 2020-12-30 12:02:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4276a664c2bbe8b5917070e6a09f454925474f01

commit 4276a664c2bbe8b5917070e6a09f454925474f01
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2020-12-30 12:02:16 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2020-12-30 12:02:53 +0000

    net-mail/mailbase-1.6: add Prefix keywords
    
    Closes: https://bugs.gentoo.org/761772
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 net-mail/mailbase/mailbase-1.6.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Fabian Groffen gentoo-dev 2020-12-30 12:03:20 UTC
(In reply to Eray Aslan from comment #4)
> please let me know if mailbase-1.6 works for prefix.  thank you

yes this works fine, thanks!