Bug 761247 – dev-util/radare2-4.5.1 contains bundled libraries

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Esteve Varela Colominas 2020-12-22 12:25:10 UTC]

Specifically, it bundles:
- sys-libs/zlib (--with-syszip)
- dev-libs/libzip (--with-syszip)
- dev-libs/xxhash (--with-sysxxhash)
- sys-apps/file (--with-sysmagic)

It'd be nice if these libraries would be linked from system packages instead. It seems app-arch/lz4 is also bundled, but it doesn't seem to be compiled, and the configure script provides no option, though meson.build does.

[Comment 1 Sergei Trofimovich (RETIRED) 2020-12-23 00:04:05 UTC]

That sounds reasonable. Worth checking if radare2 has any local patches that would make unbundling problematic. Do you want to prepare a 'git am'-able patch against ::gentoo tree?

[Comment 2 Esteve Varela Colominas 2020-12-24 17:06:16 UTC]

Created attachment 679386 [details, diff]
Formatted patch

I'm not sure if I'm doing this right as I know next to nothing about proper Gentoo policy, and idk if this change warrants a new -r revision, but I bumped it anyway.

[Comment 3 Esteve Varela Colominas 2020-12-24 17:09:32 UTC]

Created attachment 679389 [details, diff]
Additional patch

Also adding a patch to replace the docdir patch with a sed -i line, to allow it to still work with different package revisions as well as the live package...

I've tested it and it seems to work.

[Comment 4 Sergei Trofimovich (RETIRED) 2020-12-24 18:01:52 UTC]

Pushed both patches as is:
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd1c0bf77415b5b34ad39d1cfbb58888a082c052
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b65a733dff63706b0f5025107a50e9e4b9afae9f

Thank you!