Bug 760567

Summary:	app-crypt/tpm2-tools-4.3.0 make stage calls git
Product:	Gentoo Linux	Reporter:	Jonathan Davies <jpds>
Component:	Current packages	Assignee:	Christopher Byrne <salah.coronya>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jstein, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/18721
Whiteboard:
Package list:		Runtime testing required:	---

Description Jonathan Davies 2020-12-18 00:16:39 UTC

app-crypt/tpm2-tools's make stage calls git:

>>> Emerging (1 of 1) app-crypt/tpm2-tools-4.3.0::gentoo
 * tpm2-tools-4.3.0.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                                                                                                                                                                               [ ok ]
>>> Unpacking source...
>>> Unpacking tpm2-tools-4.3.0.tar.gz to /var/tmp/portage/app-crypt/tpm2-tools-4.3.0/work
>>> Source unpacked in /var/tmp/portage/app-crypt/tpm2-tools-4.3.0/work
>>> Preparing source in /var/tmp/portage/app-crypt/tpm2-tools-4.3.0/work/tpm2-tools-4.3.0 ...
 * Running eautoreconf in '/var/tmp/portage/app-crypt/tpm2-tools-4.3.0/work/tpm2-tools-4.3.0' ...
 * Running libtoolize --install --copy --force --automake ...                                                                                                                                                                                                                                                                                                                        [ ok ]
 * Running aclocal -I m4 --install ...                                                                                                                                                                                                                                                                                                                                               [ ok ]
 * Running autoconf --force ...                                                                                                                                                                                                                                                                                                                                                      [ ok ]
 * Running autoheader ...                                                                                                                                                                                                                                                                                                                                                            [ ok ]
 * Running automake --add-missing --copy --foreign --force-missing ...                                                                                                                                                                                                                                                                                                               [ ok ]
 * Running elibtoolize in: tpm2-tools-4.3.0/
 *   Applying portage/1.2.0 patch ...
 *   Applying sed/1.5.6 patch ...
 *   Applying as-needed/2.4.3 patch ...
 * Applying tpm2-tools-4.2.1-libressl.patch ...                                                                                                                                                                                                                                                                                                                                      [ ok ]
 * Applying tpm2-tools-4.3.0-Remove-WError.patch ...                                                                                                                                                                                                                                                                                                                                 [ ok ]
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/app-crypt/tpm2-tools-4.3.0/work/tpm2-tools-4.3.0 ...
 * econf: updating tpm2-tools-4.3.0/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating tpm2-tools-4.3.0/config.sub with /usr/share/gnuconfig/config.sub
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/tpm2-tools-4.3.0 --htmldir=/usr/share/doc/tpm2-tools-4.3.0/html --with-sysroot=/ --libdir=/usr/lib64 --enable-fapi --enable-hardening
checking whether to enable debugging... no
checking for x86_64-pc-linux-gnu-gcc... x86_64-pc-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether x86_64-pc-linux-gnu-gcc accepts -g... yes
checking for x86_64-pc-linux-gnu-gcc option to accept ISO C89... none needed
checking whether x86_64-pc-linux-gnu-gcc understands -c and -o together... yes
checking whether ln -s works... yes
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by x86_64-pc-linux-gnu-gcc... /usr/x86_64-pc-linux-gnu/bin/ld
checking if the linker (/usr/x86_64-pc-linux-gnu/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/x86_64-pc-linux-gnu-nm -B
checking the name lister (/usr/bin/x86_64-pc-linux-gnu-nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/x86_64-pc-linux-gnu/bin/ld option to reload object files... -r
checking for x86_64-pc-linux-gnu-objdump... x86_64-pc-linux-gnu-objdump
checking how to recognize dependent libraries... pass_all
checking for x86_64-pc-linux-gnu-dlltool... no
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for x86_64-pc-linux-gnu-ar... x86_64-pc-linux-gnu-ar
checking for archiver @FILE support... @
checking for x86_64-pc-linux-gnu-strip... x86_64-pc-linux-gnu-strip
checking for x86_64-pc-linux-gnu-ranlib... x86_64-pc-linux-gnu-ranlib
checking for gawk... gawk
checking command to parse /usr/bin/x86_64-pc-linux-gnu-nm -B output from x86_64-pc-linux-gnu-gcc object... ok
checking for sysroot... /
checking for a working dd... /bin/dd
checking how to truncate binary pipes... /bin/dd bs=4096 count=1
checking for x86_64-pc-linux-gnu-mt... no
checking for mt... no
checking if : is a manifest tool... no
checking how to run the C preprocessor... x86_64-pc-linux-gnu-gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if x86_64-pc-linux-gnu-gcc supports -fno-rtti -fno-exceptions... no
checking for x86_64-pc-linux-gnu-gcc option to produce PIC... -fPIC -DPIC
checking if x86_64-pc-linux-gnu-gcc PIC flag -fPIC -DPIC works... yes
checking if x86_64-pc-linux-gnu-gcc static flag -static works... yes
checking if x86_64-pc-linux-gnu-gcc supports -c -o file.o... yes
checking if x86_64-pc-linux-gnu-gcc supports -c -o file.o... (cached) yes
checking whether the x86_64-pc-linux-gnu-gcc linker (/usr/x86_64-pc-linux-gnu/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for a BSD-compatible install... /usr/lib/portage/python3.8/ebuild-helpers/xattr/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking whether make sets $(MAKE)... yes
checking whether make supports the include directive... yes (GNU style)
checking whether make supports nested variables... yes
checking dependency style of x86_64-pc-linux-gnu-gcc... none
checking whether make supports nested variables... (cached) yes
checking whether to build with code coverage support... no
checking for pandoc... no
configure: WARNING: Required executable pandoc not found, man pages will not be built
checking for x86_64-pc-linux-gnu-pkg-config... /usr/bin/x86_64-pc-linux-gnu-pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for TSS2_FAPI... yes
checking for TSS2_FAPI_3_0... no
checking for TSS2_ESYS_3_0... no
checking for TSS2_ESYS_2_3... yes
checking for TSS2_TCTILDR... yes
checking for TSS2_MU... yes
checking for TSS2_RC... yes
checking for TSS2_SYS... yes
checking for CRYPTO... yes
checking for CURL... yes
checking for UUID... yes
checking whether C compiler accepts -Wall... yes
checking whether C compiler accepts -Wextra... yes
checking whether C compiler accepts -Werror... yes
checking whether C compiler accepts -Wformat... yes
checking whether C compiler accepts -Wformat-security... yes
checking whether C compiler accepts -Wstack-protector... yes
checking whether C compiler accepts -fstack-protector-all... yes
checking whether C compiler accepts -Wstrict-overflow=5... yes
checking whether C compiler accepts -Wbool-compare... yes
checking whether C compiler accepts -O2... yes
checking whether to add -D_FORTIFY_SOURCE=2 to CPPFLAGS... no
checking whether C compiler accepts -fPIC... yes
checking whether the linker accepts -shared... yes
checking whether C compiler accepts -fPIE... yes
checking whether the linker accepts -pie... yes
checking whether the linker accepts -Wl,-z,relro... yes
checking whether the linker accepts -Wl,-z,now... yes
checking whether C compiler accepts -D_GNU_SOURCE... yes
checking whether C compiler accepts -Wstringop-overflow=4... yes
checking whether C compiler accepts -Wstringop-truncation... yes
checking whether C compiler accepts -Wduplicated-branches... yes
checking whether C compiler accepts -Wduplicated-cond... yes
checking whether C compiler accepts -fdata-sections... yes
checking whether C compiler accepts -ffunction-sections... yes
checking whether the linker accepts -Wl,--gc-sections... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating lib/config.h
config.status: executing libtool commands
config.status: executing depfiles commands

    - tpm2-tools: 
    - Man pages: no
    - Unit tests: no
    

>>> Source configured.
>>> Compiling source in /var/tmp/portage/app-crypt/tpm2-tools-4.3.0/work/tpm2-tools-4.3.0 ...
make -j4 
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /var/tmp/portage/app-crypt/tpm2-tools-4.3.0/work/tpm2-tools-4.3.0/missing aclocal-1.16 -I m4 --install
sh: git: command not found
sh: git: command not found
sh: git: command not found
sh: git: command not found
sh: git: command not found
sh: git: command not found
sh: git: command not found
sh: git: command not found
sh: git: command not found
sh: git: command not found
sh: git: command not found
...

It appears to use this to embed the version numbers into the binaries. If git is not installed, one ends up with:

$ tpm2_createprimary -v
tool="tpm2_createprimary" version="" tctis="libtss2-tctildr" tcti-default=tcti-device

Comment 1 Larry the Git Cow gentoo-dev

2021-01-20 14:13:51 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=285ff66c5ae45705faa8d171a24afa4c8fba06e2

commit 285ff66c5ae45705faa8d171a24afa4c8fba06e2
Author:     Salah Coronya <salah.coronya@gmail.com>
AuthorDate: 2020-12-19 02:56:00 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-20 14:13:40 +0000

    app-crypt/tpm2-tools: Don't let configure run git, add missing dep
    
    Closes: https://bugs.gentoo.org/760567
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-crypt/tpm2-tools/tpm2-tools-5.0-r1.ebuild | 46 +++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5ec8281ec77b01416c4a85d3bf7a56e22d71803

commit b5ec8281ec77b01416c4a85d3bf7a56e22d71803
Author:     Salah Coronya <salah.coronya@gmail.com>
AuthorDate: 2020-12-19 02:50:12 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-20 14:13:40 +0000

    app-crypt/tpm2-tools: Don't let configure run git, add missing dep
    
    Closes: https://bugs.gentoo.org/760567
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-crypt/tpm2-tools/tpm2-tools-4.3.0-r1.ebuild | 46 +++++++++++++++++++++++++
 1 file changed, 46 insertions(+)