Bug 759796 – dev-libs/s2n-0.10.21 uses -Werror for build

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2020-12-13 14:00:18 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/s2n-0.10.21 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

[Comment 1 Sven Eden 2020-12-14 16:41:02 UTC]

PR is submitted.

[Comment 2 Larry the Git Cow 2020-12-17 15:04:51 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8bb288997adf7e4dbe498bfa4ff3baed3e42c455

commit 8bb288997adf7e4dbe498bfa4ff3baed3e42c455
Author:     Sven Eden <[e-mail]>
AuthorDate: 2020-12-14 16:37:48 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2020-12-17 15:04:42 +0000

    dev-libs/s2n: Fix USE="test" and remove -Werror
    
    USE="test" was broken, because building of a shared library does not
    work at the moment.
    Fixed by removing hidden default visibility.
    See: https://github.com/awslabs/s2n/issues/2401
    
    -Werror is not recommended for releases and should always be disabled
    when encountered in build-logs, because there are numerous cases
    where this breaks without purpose.
    
    Closes: https://bugs.gentoo.org/759796
    Closes: https://bugs.gentoo.org/759799
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sven Eden <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/18651
    Signed-off-by: Joonas Niilola <[e-mail]>

 dev-libs/s2n/files/s2n-0.10.21-remove_Werror.patch | 22 ++++++++++++++++++++++
 .../{s2n-0.10.21.ebuild => s2n-0.10.21-r1.ebuild}  | 15 +++++++++++++--
 2 files changed, 35 insertions(+), 2 deletions(-)