Bug 759532

Summary:	kde-apps/knights-20.08.3: dev-qt/qtspeech automagic?
Product:	Gentoo Linux	Reporter:	Kobboi <gentoo>
Component:	Current packages	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	games, jstein
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.kde.org/show_bug.cgi?id=430280
Whiteboard:
Package list:		Runtime testing required:	---

Description Kobboi 2020-12-11 22:03:49 UTC

On systems that happen to have dev-qt/qtspeech installed (= my binhost), /usr/bin/knights is linked against libQt5TextToSpeech.so.5.

When installing knights on one of my slave systems, that do not have dev-qt/qtspeech installed, this results in the executable failing to start.

$ knights
knights: error while loading shared libraries: libQt5TextToSpeech.so.5: cannot open shared object file: No such file or directory

Reproducible: Always

Comment 1 Kobboi 2020-12-11 22:05:00 UTC

Additional note: USE=-speech on all packages that have that it.

Comment 2 Kobboi 2020-12-11 22:14:06 UTC

From CMakeLists.txt:

find_package(Qt5TextToSpeech ${QT_REQUIRED_VERSION} QUIET)
set_package_properties(Qt5TextToSpeech PROPERTIES
   PURPOSE "Speaking of opponents moves")
if (Qt5TextToSpeech_FOUND)
   add_definitions(-DHAVE_SPEECH)
endif ()

Nowhere in the ebuild is the package configured to enable/disable speech support.

Comment 3 Kobboi 2020-12-11 22:22:17 UTC

I'll create a github PR for this, if that's OK

Comment 4 Kobboi 2020-12-11 22:26:18 UTC

Or do you want me to take it upstream first?

Comment 5 Kobboi 2020-12-11 22:32:36 UTC

Logged as https://bugs.kde.org/show_bug.cgi?id=430280

Comment 6 Larry the Git Cow gentoo-dev

2020-12-12 13:17:23 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=d7807fb62d647c70a3e3ed8f96ca72e7571aec25

commit d7807fb62d647c70a3e3ed8f96ca72e7571aec25
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-12-12 13:17:00 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-12-12 13:17:00 +0000

    kde-apps/knights: Fix IUSE=speech automagic
    
    Closes: https://bugs.gentoo.org/759532
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/knights/knights-20.12.0.ebuild       | 7 +++++++
 kde-apps/knights/knights-20.12.49.9999.ebuild | 7 +++++++
 kde-apps/knights/knights-9999.ebuild          | 7 +++++++
 3 files changed, 21 insertions(+)

Comment 7 Larry the Git Cow gentoo-dev

2020-12-12 18:02:40 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a4c3662537988b169d91cbba302d5d1958620faf

commit a4c3662537988b169d91cbba302d5d1958620faf
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-12-12 13:17:00 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-12-12 17:31:50 +0000

    kde-apps/knights: Fix IUSE=speech automagic
    
    Closes: https://bugs.gentoo.org/759532
    Reported-by: Christophe Lermytte <gentoo@lermytte.be>
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
    (cherry picked from commit d7807fb62d647c70a3e3ed8f96ca72e7571aec25)

 kde-apps/knights/knights-20.08.3.ebuild | 7 +++++++
 1 file changed, 7 insertions(+)