| Summary: | sci-libs/cddlib-094m: installs version 0.94j instead | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jouni Kosonen <jouni.kosonen> |
| Component: | Current packages | Assignee: | Michael Orlitzky <mjo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | frp.bissey, jstein, proxy-maint, sci-mathematics |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | emerge --info sci-libs/cddlib-094m (local copy, patched as shown) | ||
Created attachment 678037 [details]
emerge --info sci-libs/cddlib-094m (local copy, patched as shown)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=680b05608511a8426e41e5be14b265dd765960f3 commit 680b05608511a8426e41e5be14b265dd765960f3 Author: Michael Orlitzky <mjo@gentoo.org> AuthorDate: 2020-12-12 12:14:42 +0000 Commit: Michael Orlitzky <mjo@gentoo.org> CommitDate: 2020-12-12 12:14:42 +0000 sci-libs/cddlib: new 094m revision to install the correct version. There's an internal variable in this ebuild that needs to be updated for every new version... and wasn't. Thanks to Jouni Kosonen who noticed the mistake. Closes: https://bugs.gentoo.org/759520 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Michael Orlitzky <mjo@gentoo.org> sci-libs/cddlib/Manifest | 1 + sci-libs/cddlib/{cddlib-094m.ebuild => cddlib-094m-r1.ebuild} | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) "now we are screwed" indeed :( (In reply to Michael Orlitzky from comment #3) > "now we are screwed" indeed :( May be we just lack experience and imagination. This is bashism as far as I know, but it would be an improvement on the current situation MY_PV="${PV:0:1}.${PV:1}" Not sure what will come after 0.94z :) we'll have to revisit when versioning changes. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0cd3b9d029b36e2f679143bbd9901c9493746390 commit 0cd3b9d029b36e2f679143bbd9901c9493746390 Author: Michael Orlitzky <mjo@gentoo.org> AuthorDate: 2020-12-14 14:39:18 +0000 Commit: Michael Orlitzky <mjo@gentoo.org> CommitDate: 2020-12-14 23:00:28 +0000 sci-libs/cddlib: make MY_PV assignment more reliable. François Bissey came up with a better way (using bash substrings) to compute MY_PV from PV in these ebuilds. It won't work forever, but it should be OK for a few more versions, and the failure mode is nicer than the present one of silently downloading the wrong version. Bug: https://bugs.gentoo.org/759520 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Michael Orlitzky <mjo@gentoo.org> sci-libs/cddlib/cddlib-094m-r1.ebuild | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) |
--- a/sci-libs/cddlib/cddlib-094m.ebuild +++ b/sci-libs/cddlib/cddlib-094m.ebuild @@ -5,7 +5,7 @@ EAPI=7 # This should have been dealt with versionator in the direction # 0.94x -> 094x - now we are screwed. -MY_PV="0.94j" +MY_PV="0.94m" MY_P="${PN}-${MY_PV}" DESCRIPTION="C library implementing the Double Description Method" HOMEPAGE="https://www.inf.ethz.ch/personal/fukudak/cdd_home/" Reproducible: Always