Bug 759400 – dev-util/lcov-1.15 installs perl scripts with unprefixed #! lines

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Nick Bowler 2020-12-10 19:51:01 UTC]

Created attachment 677692 [details, diff]
proposed patch

On prefix installs, the dev-util/lcov package installs several perl
scripts that begin with the shebang line

  #!/usr/bin/perl

which means the scripts are not run with the correct prefixed perl.  This
results in the obvious runtime failures.  The problematic scripts are:

  $EPREFIX/usr/bin/gendesc
  $EPREFIX/usr/bin/genpng
  $EPREFIX/usr/bin/geninfo
  $EPREFIX/usr/bin/genhtml
  $EPREFIX/usr/bin/lcov

The ebuild currently does patch some of the scripts but for whatever
reason the actually-installed scripts appear to have been missed...

The lcov build system rewrites the shebang lines when installing, and
the correct value can be set by passing LCOV_PERL_PATH to make install.

Portage 3.0.12 (python 3.8.6-final-0, default/linux/amd64/17.0, gcc-10.2.0, glibc-2.32-r5, 3.10.0-957.5.1.el7.x86_64 x86_64)
=================================================================
System uname: Linux-3.10.0-957.5.1.el7.x86_64-x86_64-Intel-R-_Core-TM-_i7-4790_CPU_@_3.60GHz-with-glibc2.2.5
KiB Mem:    16204384 total,   1922860 free
KiB Swap:   32605180 total,  32547580 free
Timestamp of repository gentoo: Wed, 09 Dec 2020 00:45:01 +0000
sh bash 5.0_p18
ld GNU ld (Gentoo 2.34 p4) 2.34.0
ccache version 3.7.9 [enabled]
app-shells/bash:          5.0_p18::gentoo
dev-lang/perl:            5.30.3-r1::gentoo
dev-lang/python:          2.7.18-r4::gentoo, 3.6.10-r2::gentoo, 3.7.9::gentoo, 3.8.6::gentoo, 3.9.0::gentoo
dev-util/ccache:          3.7.9::gentoo
dev-util/cmake:           3.17.3::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.3-r1::gentoo
sys-devel/binutils:       2.34-r1::gentoo, 2.35.1-r1::gentoo
sys-devel/gcc:            9.3.0-r2::gentoo, 10.2.0-r3::gentoo
sys-devel/gcc-config:     2.3.2-r1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.9::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r5::gentoo
Repositories:

gentoo
    location: /SCRATCH/gentoo/srv/repos/gentoo
    sync-type: webrsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-webrsync-verify-signature: true

gentoo-draconx
    location: /SCRATCH/gentoo/srv/repos/gentoo-draconx
    masters: gentoo

gentoo-fixes
    location: /SCRATCH/gentoo/srv/repos/gentoo-fixes
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=haswell -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/SCRATCH/gentoo/etc /etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/SCRATCH/gentoo/etc/env.d /SCRATCH/gentoo/etc/gentoo-release /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=haswell -pipe"
DISTDIR="/SCRATCH/gentoo/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build --autounmask --autounmask-write=n --dynamic-deps=n --unordered-display --verbose-conflicts --with-bdeps-auto=n"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance ccache config-protect-if-modified distlocks ebuild-locks fixlafiles force-prefix ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sfperms strict unknown-features-warn unmerge-logs unmerge-orphans unprivileged xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_CA.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5"
PKGDIR="/SCRATCH/gentoo/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/SCRATCH/gentoo/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/SCRATCH/gentoo/var/tmp"
USE="X acl amd64 berkdb bzip2 cli crypt cups dri exif fbcon fontconfig fortran gdbm iconv icu ipv6 jpeg lcms libglvnd libtirpc multilib ncurses nls nptl openmp pcre perl png prefix python readline seccomp split-usr ssl svg tcpd truetype unicode xattr xft xinerama zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python2_7 python3_8" RUBY_TARGETS="ruby25 ruby26" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Nick Bowler 2020-12-10 22:05:32 UTC]

Created attachment 677800 [details, diff]
fixed patch

Fix patch, EROOT is of course wrong, should be just EPREFIX.

[Comment 2 Larry the Git Cow 2023-10-12 05:28:04 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77c40aac077cba40b0dedda6b9936a100d7c865a

commit 77c40aac077cba40b0dedda6b9936a100d7c865a
Author:     Sam James <[e-mail]>
AuthorDate: 2023-10-12 05:11:35 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-10-12 05:27:32 +0000

    dev-util/lcov: add 1.16
    
    * Fix tests (just run them with -j1)
    * Fix shebangs for prefix in installed perl scripts
    
    Closes: https://bugs.gentoo.org/689730
    Closes: https://bugs.gentoo.org/759400
    Closes: https://bugs.gentoo.org/903633
    Signed-off-by: Sam James <[e-mail]>

 dev-util/lcov/Manifest         |  1 +
 dev-util/lcov/lcov-1.16.ebuild | 51 ++++++++++++++++++++++++++++++++++++++++++
 dev-util/lcov/lcov-9999.ebuild | 22 ++++++++++++------
 3 files changed, 67 insertions(+), 7 deletions(-)