Bug 759202 – gnustep-base/gnustep-base[icu] fails to compile with dev-libs/icu-68

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Luis Cáceres 2020-12-09 10:20:59 UTC]

Created attachment 677446 [details, diff]
patch for gnustep-base-1.27.0

ICU 68 public headers no longer defines macros TRUE and FALSE (see in https://unicode-org.atlassian.net/browse/ICU-21267 and http://site.icu-project.org/download/68). This leads to a compilation failure.

I'm attaching a simple patch that fixes this for me on gnustep-base-1.27.0.

[Comment 1 krator44 2020-12-10 06:44:19 UTC]

Created attachment 677533 [details, diff]
patch for gnustep-gui-0.28

attaching equivalent patch for gnustep-gui-0.28

[Comment 2 krator44 2020-12-10 07:22:20 UTC]

Created attachment 677536 [details, diff]
patch for gnustep-gui-0.28 CORRECTION

sorry about that the patch contained a typo
attaching fixed patch

[Comment 3 PrSo 2020-12-10 16:08:31 UTC]

I can confirm, that with the first patch applied gnustep-base builds just fine.
Thanks.
P.

[Comment 4 Bernard Cafarelli 2020-12-10 17:01:34 UTC]

Thanks for the report, I delayed icu bump for now locally so did not see this issue yet.

Upstream, I see -base has fix already, but -gui has apparently not, did you send it there?

I will check and apply patches on ebuilds

[Comment 5 PrSo 2020-12-10 19:32:13 UTC]

(In reply to Bernard Cafarelli from comment #4)
> Thanks for the report, I delayed icu bump for now locally so did not see
> this issue yet.
> 
> Upstream, I see -base has fix already, but -gui has apparently not, did you
> send it there?
> 
> I will check and apply patches on ebuilds

No, it wasn't me who send it upstream. I've checked only on my local system, but I'm glad to hear that fix is already there.
Best,
P.

[Comment 6 Bernard Cafarelli 2020-12-10 20:50:08 UTC]

Thanks for that, and gnustep apps seem to be OK with bumped icu (still running on my system for other packages).

I only added fixes to latest versions, which are overdue for stabling anyway

[Comment 7 Larry the Git Cow 2020-12-10 20:50:36 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89f1225543db769277015aab351e720d4a0b31ca

commit 89f1225543db769277015aab351e720d4a0b31ca
Author:     Bernard Cafarelli <[e-mail]>
AuthorDate: 2020-12-10 20:50:26 +0000
Commit:     Bernard Cafarelli <[e-mail]>
CommitDate: 2020-12-10 20:50:34 +0000

    gnustep-base/gnustep-gui: fix compilation with dev-libs/icu-68
    
    Thanks Luis Cáceres <[e-mail]> for bug report and patch
    
    Closes: https://bugs.gentoo.org/759202
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Bernard Cafarelli <[e-mail]>

 .../gnustep-gui/files/gnustep-gui-0.28.0-icu68.patch      | 15 +++++++++++++++
 gnustep-base/gnustep-gui/gnustep-gui-0.28.0.ebuild        |  2 ++
 2 files changed, 17 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=091ceaaa1be63d498cff9f287f1f60028aeba22e

commit 091ceaaa1be63d498cff9f287f1f60028aeba22e
Author:     Bernard Cafarelli <[e-mail]>
AuthorDate: 2020-12-10 20:40:45 +0000
Commit:     Bernard Cafarelli <[e-mail]>
CommitDate: 2020-12-10 20:50:34 +0000

    gnustep-base/gnustep-base: fix compilation with dev-libs/icu-68
    
    Bug: https://bugs.gentoo.org/759202
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Bernard Cafarelli <[e-mail]>

 .../files/gnustep-base-1.27.0-icu68.patch          | 31 ++++++++++++++++++++++
 .../gnustep-base/gnustep-base-1.27.0.ebuild        |  5 +++-
 2 files changed, 35 insertions(+), 1 deletion(-)