| Summary: | gui-wm/hikari: /usr/bin/hikari is still suid with USE=-suid | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Haelwenn (lanodan) Monnier <contact> |
| Component: | Current packages | Assignee: | Aisha Tammy <gentoo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | proxy-maint |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/18564 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Haelwenn (lanodan) Monnier
2020-12-07 22:01:57 UTC
Confirmed, hikari needs to be told about suid when installing, not compiling. Suggested patch:
--- hikari-2.2.2.ebuild 2020-10-31 16:09:11.000000000 +0000
+++ hikari-2.2.2.ebuild.fixed 2020-12-12 17:32:04.726623222 +0000
@@ -54,13 +54,12 @@
$(usex gamma -DWITH_GAMMACONTROL "") \
$(usex layershell -DWITH_LAYERSHELL "") \
$(usex screencopy -DWITH_SCREENCOPY "") \
- $(usex suid -DWITH_SUID "") \
$(usex virtual-io -DWITH_VIRTUAL_INPUT "") \
$(usex X -DWITH_XWAYLAND "") \
all || die
}
src_install() {
- ${MAKE} DESTDIR="${D}" PREFIX=/usr ETC_PREFIX=/ install || die
+ ${MAKE} DESTDIR="${D}" PREFIX=/usr ETC_PREFIX=/ $(usex suid -DWITH_SUID "") install || die
doman share/man/man1/hikari.1
}
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5b7e31d037c51f707d5a48480b73783f072e5fe commit b5b7e31d037c51f707d5a48480b73783f072e5fe Author: Aisha Tammy <gentoo@aisha.cc> AuthorDate: 2020-12-08 11:48:45 +0000 Commit: Aaron Bauman <bman@gentoo.org> CommitDate: 2020-12-16 02:16:29 +0000 gui-wm/hikari: fix suid flag usage was changed from WITH_SUID to WITHOUT_SUID Closes: https://bugs.gentoo.org/758968 Package-Manager: Portage-3.0.11, Repoman-3.0.2 Signed-off-by: Aisha Tammy <gentoo@aisha.cc> Closes: https://github.com/gentoo/gentoo/pull/18564 Signed-off-by: Aaron Bauman <bman@gentoo.org> gui-wm/hikari/{hikari-2.2.2.ebuild => hikari-2.2.2-r1.ebuild} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) |
