Bug 75876

Summary:	net-dialup/penggy homepage incorrect, and ebuild very messy
Product:	Gentoo Linux	Reporter:	Jonathan Smith (RETIRED) <smithj>
Component:	New packages	Assignee:	Gentoo Dialup Developers <net-dialup>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	smithj
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	proposed ebuild for penggy 2.0.1-r1

Description Jonathan Smith (RETIRED) gentoo-dev

2004-12-27 21:51:05 UTC

http://www.peng.apinc.org/ is listed as the homepage, which defaults to the french site. the english site is: http://www.peng.apinc.org/eng/

the ebuild is also very messy, and i have cleaned it up some (and also replaced the messed up homepage).

Comment 1 Jonathan Smith (RETIRED) gentoo-dev

2004-12-27 21:56:53 UTC

Created attachment 47012 [details]
proposed ebuild for penggy 2.0.1-r1

this removes ./configure steps, replacing them with econf, updates homepage,
fixes dependency (guile was listed as DEPEND, when it should have been
RDEPEND), and changes the last einfo to ewarn. overall effect: a much cleaner
ebuild

Comment 2 Mr. Bones. (RETIRED) gentoo-dev

2004-12-27 22:48:51 UTC

src_compile() isn't needed

Comment 3 Jonathan Smith (RETIRED) gentoo-dev

2004-12-28 05:21:23 UTC

i'm kinda new to ebuilds, so why is it not required? if you will look at the ebuild currently in portage, penggy-2.0.1.ebuild, it has this step. i just coppied the old ebuild and replaced what i said above, leaving major structure alone...

Comment 4 Alin Năstac (RETIRED) gentoo-dev

2004-12-28 15:06:35 UTC

src_compile isn't needed because the default implementation of this function does exactly the same.

ebuild have been modified as proposed but without releasing a new revision (no need for that because changes doesn't affect installed files).