Bug 757744

Summary:	app-editors/neovim-0.4.4: no longer builds release build
Product:	Gentoo Linux	Reporter:	fiesh
Component:	Current packages	Assignee:	Vim Maintainers <vim>
Status:	RESOLVED FIXED
Severity:	minor	CC:	sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description fiesh 2020-11-30 12:03:39 UTC

From 0.4.3 to 0.4.4, the line

CMAKE_BUILD_TYPE=Release

was removed from the neovim ebuild.  Neovim's `:checkhealth` now reports

WARNING: Non-optimized build. Nvim will be slower.

If this was intentional, a comment in the ebuild would be nice explaining why -- but I can't imagine it is?

Reproducible: Always

Comment 1 Sam James archtester

2020-11-30 12:11:56 UTC

The release type we use in Gentoo is called "Gentoo" which is equivalent to Release but also sets useful settings for CMake that we require.

It sounds like the upstream build system interprets non-"Release" as needing to run Debug mode. 

It's possible that the error is actually cosmetic - I remember bumping neovim and I hope I would have noticed if CFLAGS weren't being respected (<=> optimised). But I'll investigate this when I get time, thank you.

Comment 2 fiesh 2020-11-30 12:21:32 UTC

Oh I see, thanks for the clarification.  Then I guess this is purely cosmetic, `:checkhealth` does say

INFO: Build type: Gentoo

I suppose the correct way would be to patch Neovim to not warn about `Gentoo` as a build type then.  But still it's purely cosmetic.

Comment 3 yiqunding 2021-01-19 02:56:36 UTC

I'm using the 9999 version ebuild, and I have a similar issue.
The checkhealth command of neovim reports:

  - INFO: Build type: Gentoo
  - WARNING: Non-optimized build. Nvim will be slower.
    - ADVICE:
      - Install a different Nvim package, or rebuild with `CMAKE_BUILD_TYPE=RelWithDebInfo`.
      - https://github.com/neovim/neovim/wiki/FAQ

Comment 4 Sam James archtester

2021-01-19 03:12:27 UTC

(In reply to yiqunding from comment #3)
> I'm using the 9999 version ebuild, and I have a similar issue.
> The checkhealth command of neovim reports:
> 
>   - INFO: Build type: Gentoo
>   - WARNING: Non-optimized build. Nvim will be slower.
>     - ADVICE:
>       - Install a different Nvim package, or rebuild with
> `CMAKE_BUILD_TYPE=RelWithDebInfo`.
>       - https://github.com/neovim/neovim/wiki/FAQ

It is a completely cosmetic warning, please ignore it for now.

Comment 5 Larry the Git Cow gentoo-dev

2021-01-19 03:31:33 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d236a315dd7fb66ed292f881cdc43d2a72de805

commit 7d236a315dd7fb66ed292f881cdc43d2a72de805
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-01-19 03:31:25 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-19 03:31:25 +0000

    app-editors/neovim: explicitly mark Gentoo build type as OK
    
    No revbump because it's a minor change. Please re-install
    to pick it up if you're interested.
    
    This is completely cosmetic - the Gentoo build is already
    optimised and NOT debug, but this fixes the warning in
    :checkhealth.
    
    Closes: https://bugs.gentoo.org/757744
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 .../neovim/files/neovim-0.4.4-cmake-release-type.patch      | 13 +++++++++++++
 app-editors/neovim/neovim-0.4.4-r100.ebuild                 |  5 +++--
 app-editors/neovim/neovim-0.4.4.ebuild                      |  6 +++++-
 app-editors/neovim/neovim-9999.ebuild                       |  5 +++--
 4 files changed, 24 insertions(+), 5 deletions(-)