Summary: | net-p2p/bitcoin-core does not install rpcauth.py during src_install() phase | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jason Chan <graysonchsi> |
Component: | Current packages | Assignee: | Matt Whitlock <gentoo> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, proxy-maint |
Priority: | Normal | Keywords: | PATCH, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/33494 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | git diff of modified src_install() phase to include share/rpcauth |
Description
Jason Chan
2020-11-27 03:41:05 UTC
Not sure /usr/share makes sense...? Either it belongs in /usr/share/doc/... as an example, or /usr/bin renamed IMO (In reply to Luke-Jr from comment #1) > Not sure /usr/share makes sense...? > > Either it belongs in /usr/share/doc/... as an example, or /usr/bin renamed > IMO I agree that it is odd. I figured it'd be closest to the canonical path defined in the documentation. I'll vote for /usr/share/doc; there it can be stored in /usr/share/doc/bitcoind-x.xx.x, giving clarity on which version rpcauth.py is. Could it be possible to patch bitcoind to call rpcauth.py? I don't like the idea of adding yet another file to /usr/bin, especially considering the infrequency of needing to use rpcauth.py. Just checking up. I don't have a preference for location. It would be good to include rpcauth.py in the 0.21.0 release. Forgot this for 0.21.0, but maybe a -r1... Pondering the options, I think the best possibility is: newbin share/rpcauth/rpcauth.py bitcoind-rpcauth newdoc share/rpcauth/README.md bitcoind-rpcauth.md Installed with examples means it gets compressed, effectively making it annoying to use. > newbin share/rpcauth/rpcauth.py bitcoind-rpcauth
That would be a wonderful idea. Keeps it simple and accessible to users. Are there any other scripts that should be considered besides rpcauth.py? If so, following the /usr/bin/bitcoind-* styling would be ideal in such a case.
@matt please check if this is still valid for the new bitcoin-core ebuild. rpcauth.py doesn't get installed. If upstream had intended it to be included in the canonical installation, they would have mentioned it in Makefile.am. Under that reasoning, I do believe it would make the most sense to install it in the doc dir. To address Luke's concern, compression of the script can be disabled with `docompress -x`. The README file is redundant to install since it's just a dump of the script's --help output. Yep, I am also skeptical regarding this script. But I guess placing it uncompressed into the docdir does not hurt much. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2d23ce0f6769a00197db3e28117a7e809dc92828 commit 2d23ce0f6769a00197db3e28117a7e809dc92828 Author: Matt Whitlock <gentoo@mattwhitlock.name> AuthorDate: 2023-10-24 15:46:17 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2023-10-25 08:37:20 +0000 net-p2p/bitcoin-core: install rpcauth.py to doc dir Closes: https://bugs.gentoo.org/757102 Signed-off-by: Matt Whitlock <gentoo@mattwhitlock.name> Signed-off-by: Florian Schmaus <flow@gentoo.org> .../{bitcoin-core-25.1.ebuild => bitcoin-core-25.1-r1.ebuild} | 6 ++++++ 1 file changed, 6 insertions(+) |