Bug 756544 – mail-client/thunderbird-78.5.0 fails to compile with dev-lang/rust-1.48.0

• Product: Gentoo Linux
• Status: RESOLVED DUPLICATE

[Description Attila Tóth 2020-11-25 09:20:30 UTC]

The underlying reason is mentioned in the commit message referenced by the URL of this bug: mmx support has been removed in recent rust, while third_party packed_simd in thunderbird still contains those pieces.

 3:49.36 error[E0432]: unresolved import `crate::arch::x86_64::__m64`
 3:49.36   --> /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/api/into_bits/arch_specific.rs:51:15
 3:49.36    |
 3:49.36 51 |               $($arch_ty),*
 3:49.36    |                 ^^^^^^^^ no `__m64` in `arch::x86_64`
 3:49.36 ...
 3:49.36 86 | / impl_arch!(
 3:49.36 87 | |     [x86["x86"]: __m64], [x86_64["x86_64"]: __m64],
 3:49.36 88 | |     [arm["arm"]: int8x8_t, uint8x8_t, poly8x8_t, int16x4_t, uint16x4_t,
 3:49.36 89 | |      poly16x4_t, int32x2_t, uint32x2_t, float32x2_t, int64x1_t,
 3:49.36 ...  |
 3:49.36 96 | |     test: test_v64
 3:49.36 97 | | );
 3:49.36    | |__- in this macro invocation
 3:49.36    |
 3:49.36    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
 3:49.36 error[E0432]: unresolved import `crate::arch::x86_64::_mm_movemask_pi8`
 3:49.36   --> /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask/x86/sse.rs:47:21
 3:49.36    |
 3:49.36 47 |                 use crate::arch::x86_64::_mm_movemask_pi8;
 3:49.36    |                     ^^^^^^^^^^^^^^^^^^^^^----------------
 3:49.36    |                     |                    |
 3:49.36    |                     |                    help: a similar name exists in the module: `_mm_movemask_epi8`
 3:49.36    |                     no `_mm_movemask_pi8` in `arch::x86_64`
 3:49.37    |
 3:49.37   ::: /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask.rs:41:1
 3:49.37    |
 3:49.37 41 | impl_mask_reductions!(m8x8);
 3:49.37    | ---------------------------- in this macro invocation
 3:49.37    |
 3:49.37    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
 3:49.38 error[E0432]: unresolved import `crate::arch::x86_64::_mm_movemask_pi8`
 3:49.38   --> /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask/x86/sse.rs:62:21
 3:49.38    |
 3:49.38 62 |                 use crate::arch::x86_64::_mm_movemask_pi8;
 3:49.38    |                     ^^^^^^^^^^^^^^^^^^^^^----------------
 3:49.38    |                     |                    |
 3:49.38    |                     |                    help: a similar name exists in the module: `_mm_movemask_epi8`
 3:49.38    |                     no `_mm_movemask_pi8` in `arch::x86_64`
 3:49.38    |
 3:49.38   ::: /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask.rs:41:1
 3:49.38    |
 3:49.38 41 | impl_mask_reductions!(m8x8);
 3:49.38    | ---------------------------- in this macro invocation
 3:49.38    |
 3:49.38    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
 3:49.38 error[E0432]: unresolved import `crate::arch::x86_64::_mm_movemask_pi8`
 3:49.38   --> /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask/x86/sse.rs:47:21
 3:49.38    |
 3:49.38 47 |                 use crate::arch::x86_64::_mm_movemask_pi8;
 3:49.38    |                     ^^^^^^^^^^^^^^^^^^^^^----------------
 3:49.38    |                     |                    |
 3:49.38    |                     |                    help: a similar name exists in the module: `_mm_movemask_epi8`
 3:49.38    |                     no `_mm_movemask_pi8` in `arch::x86_64`
 3:49.38    |
 3:49.38   ::: /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask.rs:47:1
 3:49.38    |
 3:49.38 47 | impl_mask_reductions!(m16x4);
 3:49.38    | ----------------------------- in this macro invocation
 3:49.38    |
 3:49.38    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
 3:49.38 error[E0432]: unresolved import `crate::arch::x86_64::_mm_movemask_pi8`
 3:49.38   --> /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask/x86/sse.rs:62:21
 3:49.38    |
 3:49.38 62 |                 use crate::arch::x86_64::_mm_movemask_pi8;
 3:49.38    |                     ^^^^^^^^^^^^^^^^^^^^^----------------
 3:49.38    |                     |                    |
 3:49.38    |                     |                    help: a similar name exists in the module: `_mm_movemask_epi8`
 3:49.38    |                     no `_mm_movemask_pi8` in `arch::x86_64`
 3:49.39    |
 3:49.39   ::: /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask.rs:47:1
 3:49.39    |
 3:49.39 47 | impl_mask_reductions!(m16x4);
 3:49.39    | ----------------------------- in this macro invocation
 3:49.39    |
 3:49.39    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
 3:49.39 error[E0432]: unresolved import `crate::arch::x86_64::_mm_movemask_pi8`
 3:49.39   --> /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask/x86/sse.rs:47:21
 3:49.39    |
 3:49.39 47 |                 use crate::arch::x86_64::_mm_movemask_pi8;
 3:49.39    |                     ^^^^^^^^^^^^^^^^^^^^^----------------
 3:49.39    |                     |                    |
 3:49.39    |                     |                    help: a similar name exists in the module: `_mm_movemask_epi8`
 3:49.39    |                     no `_mm_movemask_pi8` in `arch::x86_64`
 3:49.39    |
 3:49.39   ::: /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask.rs:52:1
 3:49.39    |
 3:49.39 52 | impl_mask_reductions!(m32x2);
 3:49.39    | ----------------------------- in this macro invocation
 3:49.39    |
 3:49.39    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
 3:49.39 warning: 1 warning emitted
 3:49.39 error[E0432]: unresolved import `crate::arch::x86_64::_mm_movemask_pi8`
 3:49.39   --> /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask/x86/sse.rs:62:21
 3:49.39    |
 3:49.39 62 |                 use crate::arch::x86_64::_mm_movemask_pi8;
 3:49.39    |                     ^^^^^^^^^^^^^^^^^^^^^----------------
 3:49.39    |                     |                    |
 3:49.39    |                     |                    help: a similar name exists in the module: `_mm_movemask_epi8`
 3:49.39    |                     no `_mm_movemask_pi8` in `arch::x86_64`
 3:49.39    |
 3:49.39   ::: /var/tmp/portage/mail-client/thunderbird-78.5.0/work/thunderbird-78.5.0/third_party/rust/packed_simd/src/codegen/reductions/mask.rs:52:1
 3:49.39    |
 3:49.39 52 | impl_mask_reductions!(m32x2);
 3:49.39    | ----------------------------- in this macro invocation
 3:49.39    |
 3:49.39    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)


Reproducible: Always

[Comment 1 Attila Tóth 2020-11-25 09:22:25 UTC]

Created attachment 674821 [details, diff]
01-mmx-removed-from-rust-cranes-packed_simd-950903a66950eaff745b0a029f2051d305df1c22.patch

Patch containing the first part of the changes necessary for thunderbird to compile with recent rust-1.48.0.

[Comment 2 Attila Tóth 2020-11-25 09:23:04 UTC]

Created attachment 674824 [details, diff]
02-mmx-removed-from-rust-cranes-packed_simd-778c0706f356118c7a5dd11c06725fc6c6b84621.patch

Patch containing the second part of the changes necessary for thunderbird to compile with recent rust-1.48.0.

[Comment 3 Attila Tóth 2020-11-25 09:23:46 UTC]

Created attachment 674827 [details, diff]
03-mmx-removed-from-rust-cranes-packed_simd-a5ae240db66f5ea9837b1772a71b5808e68f40f2.patch

Patch containing the third part of the changes necessary for thunderbird to compile with recent rust-1.48.0.

[Comment 4 Attila Tóth 2020-11-25 09:24:35 UTC]

Created attachment 674830 [details, diff]
04-mmx-removed-from-rust-cranes-packed_simd-57d96e45916066fa9b5cdf2bc695e190207e78af.patch

Patch containing the fourth part of the changes necessary for thunderbird to compile with recent rust-1.48.0.

[Comment 5 Attila Tóth 2020-11-25 09:26:57 UTC]

Created attachment 674833 [details, diff]
05-mmx-removed-from-rust-cranes-packed_simd-checksum-failure.patch

Cargo punishes you upon making changes to the sources. Let's upgrade the checksums to calm down cargo. Welcome to the world of rust.

[Comment 6 Ionen Wolkens 2020-11-25 09:35:26 UTC]

Thanks for the patches but should be already fixed, see bug #756334 (which applied fixes for thunderbird, firefox, and spidermonkey).

I don't see your emerge --info to confirm but likely missing the fix, so please emerge --sync and try again.

[Comment 7 Attila Tóth 2020-11-25 09:41:25 UTC]

(In reply to Ionen Wolkens from comment #6)
> Thanks for the patches but should be already fixed, see bug #756334 (which
> applied fixes for thunderbird, firefox, and spidermonkey).
> 
> I don't see your emerge --info to confirm but likely missing the fix, so
> please emerge --sync and try again.

Thanks for the heads up. Had I found that bug, I wouldn't have spent time on this...

[Comment 8 Attila Tóth 2020-11-25 09:42:17 UTC]

*** This bug has been marked as a duplicate of bug 756334 ***